KEMBAR78
[None][fix] Update DG commit by Barry-Delaney · Pull Request #7534 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

[None][fix] Update DG commit #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

[None][fix] Update DG commit #7534

merged 1 commit into from
Sep 4, 2025

Conversation

@Barry-Delaney
Copy link
Collaborator

@Barry-Delaney Barry-Delaney commented Sep 4, 2025 •
edited by coderabbitai bot
Loading

This PR corrects the commit ID in 3rdparty/DeepGEMM.

Summary by CodeRabbit

  • Chores
    • Updated the DeepGEMM third‑party dependency to a newer revision.
    • No changes to public APIs or user-facing functionality.
    • No configuration updates required.
    • Existing workflows and integrations remain compatible.
    • Internal dependency refresh only; application behavior remains unchanged.

@Barry-Delaney
Update DG commit
0e1963b 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
@Barry-Delaney
Copy link
Collaborator Author

/bot run

@Barry-Delaney Barry-Delaney self-assigned this Sep 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2025

📝 Walkthrough

Walkthrough

Updated the 3rdparty/DeepGEMM submodule reference from commit 7b6b5563b9d4c1ae07ffbce7f78ad3ac9204827c to 67e3c4d3d09b59405fd6e7698a33db747ed96533. No other changes.

Changes

Cohort / File(s) Summary
DeepGEMM submodule
3rdparty/DeepGEMM		 Submodule pointer updated from 7b6b5563b9d4c1ae07ffbce7f78ad3ac9204827c to 67e3c4d3d09b59405fd6e7698a33db747ed96533

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • zongfeijing
  • litaotju
  • lucaslie
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
3rdparty/DeepGEMM (1)

1-1: Optional: prefer a tagged ref for release branches.

If an upstream tag covers this commit, consider pinning to the tag in release branches to improve traceability.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d32e462 and 0e1963b.

📒 Files selected for processing (1)
  • 3rdparty/DeepGEMM (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Filenames compiled into a target must be case-insensitively unique

Files:

  • 3rdparty/DeepGEMM
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
3rdparty/DeepGEMM (2)

1-1: LGTM — submodule pointer corrected.

Change is scoped to updating the DeepGEMM submodule commit. No issues spotted.

1-1: Manually verify DeepGEMM LICENSE/NOTICE changes
Previous submodule commit couldn’t be auto-determined, so please ensure the updated revision’s LICENSE, NOTICE, and README files haven’t changed licensing or attribution without updating our third-party docs.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17662 [ run ] triggered by Bot

@Barry-Delaney Barry-Delaney enabled auto-merge (squash) September 4, 2025 09:22
@tensorrt-cicd
Copy link
Collaborator

PR_Github #17662 [ run ] completed with state SUCCESS
/LLM/release-1.1.0rc2/L0_MergeRequest_PR pipeline #65 completed with status: 'SUCCESS'

@Barry-Delaney Barry-Delaney merged commit 9644d24 into NVIDIA:release/1.1.0rc2 Sep 4, 2025
7 checks passed
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 15, 2025
@Barry-Delaney
[None][fix] Update DG commit (NVIDIA#7534)
9da50c0 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG commit (NVIDIA#7534)
7ea492e 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG commit (NVIDIA#7534)
7d65bf6 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG commit (NVIDIA#7534)
6c8f0c3 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 18, 2025
@Barry-Delaney
[None][fix] Update DG commit (NVIDIA#7534)
d6e1515 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@lfr-0531 lfr-0531 lfr-0531 approved these changes

@litaotju litaotju Awaiting requested review from litaotju

Assignees

@Barry-Delaney Barry-Delaney

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Delaney @tensorrt-cicd @lfr-0531