[None][ci] Increase the number of retries in docker image generation #7557

chzblych · 2025-09-05T06:38:09Z

Summary by CodeRabbit

Chores
- Improved CI/CD reliability by increasing retry attempts and extending randomized backoff for network-dependent build steps, reducing transient failures during image fetches and related operations.
- Applied across dependent and main build stages and final commands to stabilize pipelines.
- Users benefit from more predictable release cadence and fewer build-related delays.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

coderabbitai · 2025-09-05T06:43:10Z

📝 Walkthrough

Walkthrough

The Jenkins pipeline file jenkins/BuildDockerImage.groovy increases llmExecStepWithRetry numRetries to 6 at four call sites and widens randomSleep for docker pull-related steps to a 600–1199 second window. No other parameters or public signatures changed.

Changes

Cohort / File(s)	Summary of Changes
Jenkins pipeline retry/backoff adjustments `jenkins/BuildDockerImage.groovy`	- Increased llmExecStepWithRetry `numRetries` from 3 to 6 across dependent build, main build, final command, and NSPECT steps - Expanded randomSleep used around docker pull-related steps from 300–599s to 600–1199s - No changes to `shortCommondRunTimeMax` or exported interfaces

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant J as Jenkins Pipeline
  participant S as Step Wrapper (llmExecStepWithRetry)
  participant D as Docker Registry
  participant M as Make/Build

  Note over J,S: Updated control flow: numRetries=6 and randomSleep=600–1199s

  J->>S: Dependent stage: docker pull
  rect rgba(230,240,255,0.6)
    loop Up to 6 retries
      S->>D: docker pull
      alt failure
        S-->>S: randomSleep(600–1199s)
      else success
        S-->>J: proceed
      end
    end
  end

  J->>S: Dependent stage: make
  S->>M: make (retries up to 6)

  J->>S: Main stage: docker pull
  S->>D: docker pull (with retry + randomSleep)

  J->>S: Main stage: make
  S->>M: make (retries up to 6)

  J->>S: NSPECT-related step
  S-->>J: run (retries up to 6)

  J->>S: Final command step
  S-->>J: run (retries up to 6)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

[None][fix] Fix a typo in the Slurm CI codes (#7485) #7538 — Adjusts the same NSPECT invocation in jenkins/BuildDockerImage.groovy by introducing llmExecStepWithRetry (numRetries: 3); this PR extends that to 6 and widens randomSleep.

Suggested reviewers

venkywonka
kxdc

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

jenkins/BuildDockerImage.groovy (3)

298-308: Retries + longer jitter: good; switch to ThreadLocalRandom and make bounds explicit

The change improves resilience. Minor refactor to avoid double/float truncation and to make the bounds explicit.

Apply this diff:

-                def randomSleep = (Math.random() * 600 + 600).toInteger()
+                def randomSleepMin = 600
+                def randomSleepMax = 1200  // exclusive
+                def randomSleep = java.util.concurrent.ThreadLocalRandom.current().nextInt(randomSleepMin, randomSleepMax)
-                trtllm_utils.llmExecStepWithRetry(this, script: "docker pull ${TRITON_IMAGE}:${TRITON_BASE_TAG}", sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
+                trtllm_utils.llmExecStepWithRetry(this, script: "docker pull ${TRITON_IMAGE}:${TRITON_BASE_TAG}", sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
@@
-                """, sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
+                """, sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)

Also consider exponential backoff with jitter in llmExecStepWithRetry to avoid worst-case 20 min waits per attempt across many parallel jobs.

327-337: Duplicate jitter logic: DRY and consistent bounds

Mirror the ThreadLocalRandom refactor here to keep behavior consistent and readable.

Apply this diff:

-            def randomSleep = (Math.random() * 600 + 600).toInteger()
+            def randomSleepMin = 600
+            def randomSleepMax = 1200  // exclusive
+            def randomSleep = java.util.concurrent.ThreadLocalRandom.current().nextInt(randomSleepMin, randomSleepMax)
-            trtllm_utils.llmExecStepWithRetry(this, script: "docker pull ${TRITON_IMAGE}:${TRITON_BASE_TAG}", sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
+            trtllm_utils.llmExecStepWithRetry(this, script: "docker pull ${TRITON_IMAGE}:${TRITON_BASE_TAG}", sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
@@
-            """, sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)
+            """, sleepInSecs: randomSleep, numRetries: 6, shortCommondRunTimeMax: 7200)

689-689: NSPECT step: add jittered sleep to avoid hot-loop retries

The other steps use jitter; mirror it here to reduce thundering herd on failures.

Apply this diff:

-                            trtllm_utils.llmExecStepWithRetry(this, script: cmd, numRetries: 6, shortCommondRunTimeMax: 7200)
+                            def nspectSleep = java.util.concurrent.ThreadLocalRandom.current().nextInt(60, 180)
+                            trtllm_utils.llmExecStepWithRetry(this, script: cmd, sleepInSecs: nspectSleep, numRetries: 6, shortCommondRunTimeMax: 7200)

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3962d and d5d35e6.

📒 Files selected for processing (1)

jenkins/BuildDockerImage.groovy (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

jenkins/BuildDockerImage.groovy (1)

298-299: Guard against excessive total wait vs pipeline timeout

With 6 retries and 600–1199s sleeps, worst-case per step adds ~100 minutes of delay (excluding work time). Across multiple stages in parallel, this can push the 24h pipeline timeout.

Please confirm recent runs won’t hit the global 24h timeout; if close, consider:

lowering sleep window or retries on non-critical pulls,

using exponential backoff with max cap,

exposing retries/sleep bounds as Jenkins parameters for quick tuning.

…7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

…VIDIA#7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

…VIDIA#7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

…VIDIA#7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

[None][ci] Increase the number of retries in docker image generation

d5d35e6

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych requested review from a team as code owners September 5, 2025 06:38

chzblych requested review from omera-nv and yuanjingx87 September 5, 2025 06:38

EmmaQiaoCh approved these changes Sep 5, 2025

View reviewed changes

coderabbitai bot reviewed Sep 5, 2025

View reviewed changes

chzblych merged commit 4195010 into NVIDIA:main Sep 5, 2025
6 of 8 checks passed

chzblych deleted the yanchaol-docker branch September 5, 2025 06:47

chzblych added a commit that referenced this pull request Sep 6, 2025

[None][ci] Increase the number of retries in docker image generation (#…

5cf4f19

…7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych added a commit that referenced this pull request Sep 6, 2025

[None][ci] Increase the number of retries in docker image generation (#…

2cb5b9f

…7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 9, 2025

[None][ci] Increase the number of retries in docker image generation (N…

c6a5afa

…VIDIA#7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025

[None][ci] Increase the number of retries in docker image generation (N…

60eb162

…VIDIA#7557) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][ci] Increase the number of retries in docker image generation #7557

[None][ci] Increase the number of retries in docker image generation #7557

Uh oh!

chzblych commented Sep 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 5, 2025

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[None][ci] Increase the number of retries in docker image generation #7557

[None][ci] Increase the number of retries in docker image generation #7557

Uh oh!

Conversation

chzblych commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Sep 5, 2025

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chzblych commented Sep 5, 2025 •

edited

Loading