Fallback to AppLocker after WldpCanExecuteFile
#24912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
TravisEz13
reviewed
Jan 31, 2025
TravisEz13
reviewed
Jan 31, 2025
|
/azp run powershell-ci-macos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
microsoft-github-policy-service
bot
added
the
Review - Needed
jborean93
reviewed
Feb 21, 2025
|
|
||
| return modernMode switch | ||
| { | ||
| SystemScriptFileEnforcement.Block => SystemEnforcementMode.Enforce, |
There was a problem hiding this comment.
Won't/shouldn't this not be the case as per the above and it would be better to throw the exception in the default branch?
TravisEz13
added
the
CL-Engine
daxian-dbw
reviewed
Mar 12, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
📣 Hey @SeeminglyScience, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
microsoft-github-policy-service
bot
removed
the
Review - Needed
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Mar 24, 2025
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
9 tasks
Sysoiev-Yurii
pushed a commit
to Sysoiev-Yurii/PowerShell
that referenced
this pull request
May 12, 2025
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
After #17247, AppLocker was no longer being checked if the Windows API
WldpCanExecuteFilewas present. With the changes in this PR, fallback to AppLocker will once again occur ifWldpCanExecuteFiledid not returnBlockedorAllowedConstrained.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).