KEMBAR78
Add mention of classic token in gh auth login docs by jtmcg · Pull Request #10164 · cli/cli · GitHub
Skip to content

Conversation

@jtmcg
Copy link
Contributor

@jtmcg jtmcg commented Jan 2, 2025

Closes #10131

Changes

Add mention of classic token to gh auth login docs. This copies the token labeling "Tokens (classic)" found in the UI so folks can visually match it to the cli docs

Screenshot 2025-01-02 at 10 10 19 AM

@jtmcg jtmcg requested a review from a team as a code owner January 2, 2025 18:10
@jtmcg jtmcg requested a review from BagToad January 2, 2025 18:10
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 2, 2025
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
Copy link
Member

@BagToad BagToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨ 🚀

@jtmcg jtmcg merged commit d6dba93 into trunk Jan 2, 2025
@jtmcg jtmcg deleted the jtmcg/update-auth-PAT-info branch January 2, 2025 23:29
@williammartin
Copy link
Member

This is not correct. Fine Grained PATs are absolutely supported, given general mixed levels of actual GitHub support.

@williammartin
Copy link
Member

Welllllll...maybe.

They are supported to the extent that they should work, but it probably doesn't make sense to use them with gh auth login --with-token because due to their repository level scoping, people will probably end up in extremely weird cases. It is expected that they work with GH_TOKEN.

Perhaps a little more nuance would be useful then. I'll create a PR!

@williammartin
Copy link
Member

Done #10186

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 8, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | minor | `v2.64.0` -> `v2.65.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.65.0`](https://github.com/cli/cli/releases/tag/v2.65.0): GitHub CLI 2.65.0

[Compare Source](cli/cli@v2.64.0...v2.65.0)

#### What's Changed

-   Document the base repo resolution functions by [@&#8203;williammartin](https://github.com/williammartin) in cli/cli#10110
-   Update releasing.md by [@&#8203;andyfeller](https://github.com/andyfeller) in cli/cli#10116
-   Document how to set gh-merge-base by [@&#8203;heaths](https://github.com/heaths) in cli/cli#10112
-   Upgrade golang.org/x/net to v0.33.0 by [@&#8203;jtmcg](https://github.com/jtmcg) in cli/cli#10135
-   add pending status for workflow runs by [@&#8203;dziamidchyk](https://github.com/dziamidchyk) in cli/cli#10143
-   Remove release discussion posts and clean up related block in deployment yml by [@&#8203;shauryatiwari1](https://github.com/shauryatiwari1) in cli/cli#10145
-   docs(repo): make explicit which branch is used when creating a repo by [@&#8203;nobe4](https://github.com/nobe4) in cli/cli#10163
-   feat: Add support for listing autolink references by [@&#8203;hoffm](https://github.com/hoffm) in cli/cli#10124
-   Add mention of classic token in gh auth login docs by [@&#8203;jtmcg](https://github.com/jtmcg) in cli/cli#10164
-   Feat: Allow setting security_and_analysis settings in gh repo edit by [@&#8203;ChandranshuRao14](https://github.com/ChandranshuRao14) in cli/cli#10139
-   Upgrade generated workflows by [@&#8203;jsoref](https://github.com/jsoref) in cli/cli#10181
-   Myriad fixes to provide clarity on determining tracking ref in MR create by [@&#8203;williammartin](https://github.com/williammartin) in cli/cli#10187
-   Handle missing upstream configs for `gh pr create`  by [@&#8203;cmbrose](https://github.com/cmbrose) in cli/cli#10177
-   fix(repo fork): add non-TTY output when fork is newly created by [@&#8203;aryanbhosale](https://github.com/aryanbhosale) in cli/cli#10158
-   Bump cli/go-gh for indirect security vulnerability by [@&#8203;andyfeller](https://github.com/andyfeller) in cli/cli#10190

#### New Contributors

-   [@&#8203;dziamidchyk](https://github.com/dziamidchyk) made their first contribution in cli/cli#10143
-   [@&#8203;shauryatiwari1](https://github.com/shauryatiwari1) made their first contribution in cli/cli#10145
-   [@&#8203;hoffm](https://github.com/hoffm) made their first contribution in cli/cli#10124
-   [@&#8203;ChandranshuRao14](https://github.com/ChandranshuRao14) made their first contribution in cli/cli#10139

**Full Changelog**: cli/cli@v2.64.0...v2.65.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4yIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PAT scopes - unclear correspondence between short names and long names

5 participants