-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Handle missing upstream configs for gh pr create
#10177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Though it doesn't really matter, in practice upstream is always going to come before origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are excellent improvements 🔥 Much easier to follow and I appreciate the new naming conventions that do a better job of describing what is going on. No notes ![]()
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.64.0` -> `v2.65.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.65.0`](https://github.com/cli/cli/releases/tag/v2.65.0): GitHub CLI 2.65.0 [Compare Source](cli/cli@v2.64.0...v2.65.0) #### What's Changed - Document the base repo resolution functions by [@​williammartin](https://github.com/williammartin) in cli/cli#10110 - Update releasing.md by [@​andyfeller](https://github.com/andyfeller) in cli/cli#10116 - Document how to set gh-merge-base by [@​heaths](https://github.com/heaths) in cli/cli#10112 - Upgrade golang.org/x/net to v0.33.0 by [@​jtmcg](https://github.com/jtmcg) in cli/cli#10135 - add pending status for workflow runs by [@​dziamidchyk](https://github.com/dziamidchyk) in cli/cli#10143 - Remove release discussion posts and clean up related block in deployment yml by [@​shauryatiwari1](https://github.com/shauryatiwari1) in cli/cli#10145 - docs(repo): make explicit which branch is used when creating a repo by [@​nobe4](https://github.com/nobe4) in cli/cli#10163 - feat: Add support for listing autolink references by [@​hoffm](https://github.com/hoffm) in cli/cli#10124 - Add mention of classic token in gh auth login docs by [@​jtmcg](https://github.com/jtmcg) in cli/cli#10164 - Feat: Allow setting security_and_analysis settings in gh repo edit by [@​ChandranshuRao14](https://github.com/ChandranshuRao14) in cli/cli#10139 - Upgrade generated workflows by [@​jsoref](https://github.com/jsoref) in cli/cli#10181 - Myriad fixes to provide clarity on determining tracking ref in MR create by [@​williammartin](https://github.com/williammartin) in cli/cli#10187 - Handle missing upstream configs for `gh pr create` by [@​cmbrose](https://github.com/cmbrose) in cli/cli#10177 - fix(repo fork): add non-TTY output when fork is newly created by [@​aryanbhosale](https://github.com/aryanbhosale) in cli/cli#10158 - Bump cli/go-gh for indirect security vulnerability by [@​andyfeller](https://github.com/andyfeller) in cli/cli#10190 #### New Contributors - [@​dziamidchyk](https://github.com/dziamidchyk) made their first contribution in cli/cli#10143 - [@​shauryatiwari1](https://github.com/shauryatiwari1) made their first contribution in cli/cli#10145 - [@​hoffm](https://github.com/hoffm) made their first contribution in cli/cli#10124 - [@​ChandranshuRao14](https://github.com/ChandranshuRao14) made their first contribution in cli/cli#10139 **Full Changelog**: cli/cli@v2.64.0...v2.65.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4yIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
|
this PR seems to have regressed functionality for us:
I think this should probably be reverted and revisited? it seems to no longer default to |
|
oh wait my bad, this is the fix for that problem. guess I just need to wait for the runner images to update to the latest -- disregard! |
|
Sorry about that! |
Fixes: https://github.com/github/cli/issues/730, #10188