KEMBAR78
ci: add hadolint action to workflows/lints.yml (#380) by iovanom · Pull Request #400 · dotenv-linter/dotenv-linter · GitHub
Skip to content

ci: add hadolint action to workflows/lints.yml (#380) #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2021
Merged

ci: add hadolint action to workflows/lints.yml (#380) #400

merged 3 commits into from
Mar 26, 2021

Conversation

iovanom
Copy link
Contributor

@iovanom iovanom commented Mar 24, 2021 •
edited
Loading

Add hadolint to lints workflows for check Dockerfile. Issue (#380)

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev
Copy link
Member

@iovanom 👋 Thank you for your contribution 👍

You missed this item:

  • This PR has been added to CHANGELOG.md (at the top of the list);

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 24, 2021
@mgrachev mgrachev linked an issue Mar 24, 2021 that may be closed by this pull request
Add action-hadolint #380
Closed
@iovanom
Copy link
Contributor Author

iovanom commented Mar 25, 2021 •
edited
Loading

@iovanom Thank you for your contribution

You missed this item:

  • This PR has been added to CHANGELOG.md (at the top of the list);

Should I add the CI changes to CHANGELOG ? I didn't find any CI change in CHANGELOG.md

@mgrachev
Copy link
Member

@iovanom Thank you for your contribution
You missed this item:

  • This PR has been added to CHANGELOG.md (at the top of the list);

Should I add the CI changes to CHANGELOG ? I didn't find any CI change in CHANGELOG.md

Yes, you should. E.g.:

Add action-yamllint #317 (@vk26)

@iovanom iovanom force-pushed the 380_add_action_hadolint branch from 5ef5f4d to 3aef1dd Compare March 25, 2021 19:52
@iovanom iovanom force-pushed the 380_add_action_hadolint branch from 3aef1dd to 44f5433 Compare March 25, 2021 19:54
@iovanom
Copy link
Contributor Author

iovanom commented Mar 25, 2021

@iovanom Thank you for your contribution
You missed this item:

  • This PR has been added to CHANGELOG.md (at the top of the list);

Should I add the CI changes to CHANGELOG ? I didn't find any CI change in CHANGELOG.md

Yes, you should. E.g.:

Add action-yamllint #317 (@vk26)

Done ;)

mgrachev
mgrachev previously approved these changes Mar 26, 2021
View reviewed changes
@mgrachev mgrachev merged commit 9cf34c1 into dotenv-linter:master Mar 26, 2021
@mgrachev
Copy link
Member

@iovanom Thank you for your help 👍

Ru5ty0ne pushed a commit to Ru5ty0ne/dotenv-linter that referenced this pull request Mar 29, 2021
@iovanom @mgrachev @Ru5ty0ne
ci: add hadolint action to workflows/lints.yml (dotenv-linter#380) (d…
2a299cf 
…otenv-linter#400)

* ci: add hadolint action to workflows/lints.yml (dotenv-linter#380)

* docs: update changelog

Co-authored-by: Grachev Mikhail <work@mgrachev.com>
@iovanom iovanom deleted the 380_add_action_hadolint branch March 29, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev left review comments

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Add action-hadolint

2 participants

@iovanom @mgrachev