[iOS] Fix AdaptiveTrigger not working as expected #20987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
|
Are there any updates on this? |
|
Anything new on this after MAUI's net 9 release? |
|
/rebase |
jfversluis
approved these changes
Jun 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Added changes * Fixed broken test * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* Added changes * Fixed broken test * Updated test
PureWeen
added a commit
that referenced
this pull request
Jun 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate
rmarinho
pushed a commit
that referenced
this pull request
Jun 24, 2025
* Added changes * Fixed broken test * Updated test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix AdaptiveTrigger not working as expected on iOS. The main change is that the Window on iOS did not receive change updates. When rotating the device for example without resizing the window, the AdaptiveTrigger did not work as expected.
The previous implementation was incorrect in that the frame was only updated when using scenes. However, most apps do not and this was not detected because all the maui samples use scenes. The new implementations uses a KVO on the UIWindow to update the maui window. In addition to this now working generally, the
WindowSceneDidUpdateCoordinateSpaceevent would fire for many other things - such as window activation - so we now get slightly better performance.Javier added code to use KVO to watch
framebut I (Matthew) think it will leak the things, so I (Matthew) wrapped it in a proxy object as we seem to have been doing for anything that needs to listen to platform view changes/events.Issues Fixed
Fixes #19197