[Windows] Implemented the Resize and Downsize functions in the W2DImage class #29138

HarishwaranVijayakumar · 2025-04-23T09:03:06Z

Root Cause of the issue

There is no implementation for the Resize and Downsize methods in the PlatformImage class on Windows.

Description of Change

Implemented a Resize and Downsize method in the PlatformImage class on Windows.

Issues Fixed

Fixes #16767

Tested the behaviour in the following platforms

- Windows
- Android
- Mac
- iOS

Output

Before Fix	After Fix
WindowsBeforeFix.mp4	WindowsFix1.mp4

This reverts commit ef22fa8.

This reverts commit a79de0d.

MartyIX · 2025-04-23T09:36:25Z

src/Graphics/src/Graphics/Platforms/Windows/PlatformImage.cs

+
+			using (var resizedStream = new InMemoryRandomAccessStream())
+			{
+				AsyncPump.Run(async () => await renderTarget.SaveAsync(resizedStream, CanvasBitmapFileFormat.Png));


In #23824, a AsyncPump.Run call was removed and it is not needed. I believe it should be possible to mimick what was done here:

https://github.com/dotnet/maui/pull/23824/files#diff-7809b7d3f7611c78ba9e346d0e686e7f564ec68d1c25bc19bee122f9f9f1439dR179-R180

Could you do some tests without AsyncPump.Run? Can lead to thread blocking issues.

@MartyIX, As suggested I have modified the code

jsuarezruiz · 2025-04-23T10:49:46Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issue28725.cs

+		App.WaitForElement(buttonId);
+		App.Click(buttonId);
+		App.WaitForElement("Label");
+		VerifyScreenshotOrSetException(ref exception, screenshotName);


Pending snapshots on Android and Windows.

jsuarezruiz · 2025-04-23T11:05:36Z

src/Graphics/src/Graphics/Platforms/Windows/PlatformImage.cs

+
+			using (var resizedStream = new InMemoryRandomAccessStream())
+			{
+				AsyncPump.Run(async () => await renderTarget.SaveAsync(resizedStream, CanvasBitmapFileFormat.Png));


Could you do some tests without AsyncPump.Run? Can lead to thread blocking issues.

jsuarezruiz · 2025-04-25T06:08:33Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-04-25T06:08:45Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit cac6f45.

jsuarezruiz · 2025-05-06T06:44:07Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-06T06:44:18Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Graphics/src/Graphics/Platforms/Windows/PlatformImage.cs

jsuarezruiz · 2025-06-06T06:48:51Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-06T06:49:02Z

Azure Pipelines successfully started running 1 pipeline(s).

…ge class (#29138) * Fix for GraphicsView ImagePaint * update for the graphics view imagePaint * Added testcase * Implementation for Downsize * Revert "Added testcase" This reverts commit ef22fa8. * Added test case * Added CreateResizedMethod * Implemented Resize method * Fix modification * Added testcase * Revert "Added test case" This reverts commit a79de0d. * Updated the changes * Update changes * Updated the testcase * Commited the changes * Updating code * Update TestCase * Code Update * Modify TestCase * TestCase Updation * Code update * Adding Snapshots * Added snapshots * Revert "Added snapshots" This reverts commit cac6f45. * Refactor code

@Shalini-Ashokan

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate

…ge class (#29138) * Fix for GraphicsView ImagePaint * update for the graphics view imagePaint * Added testcase * Implementation for Downsize * Revert "Added testcase" This reverts commit ef22fa8. * Added test case * Added CreateResizedMethod * Implemented Resize method * Fix modification * Added testcase * Revert "Added test case" This reverts commit a79de0d. * Updated the changes * Update changes * Updated the testcase * Commited the changes * Updating code * Update TestCase * Code Update * Modify TestCase * TestCase Updation * Code update * Adding Snapshots * Added snapshots * Revert "Added snapshots" This reverts commit cac6f45. * Refactor code

…ge class (dotnet#29138) * Fix for GraphicsView ImagePaint * update for the graphics view imagePaint * Added testcase * Implementation for Downsize * Revert "Added testcase" This reverts commit ef22fa8. * Added test case * Added CreateResizedMethod * Implemented Resize method * Fix modification * Added testcase * Revert "Added test case" This reverts commit a79de0d. * Updated the changes * Update changes * Updated the testcase * Commited the changes * Updating code * Update TestCase * Code Update * Modify TestCase * TestCase Updation * Code update * Adding Snapshots * Added snapshots * Revert "Added snapshots" This reverts commit cac6f45. * Refactor code

HarishwaranVijayakumar added 17 commits April 7, 2025 12:08

Fix for GraphicsView ImagePaint

d3bfe46

update for the graphics view imagePaint

f69f8be

Added testcase

ef22fa8

Implementation for Downsize

4a7ad8d

Revert "Added testcase"

87e655d

This reverts commit ef22fa8.

Added test case

a79de0d

Added CreateResizedMethod

6ad14d0

Implemented Resize method

c08e5a8

Fix modification

1177737

Added testcase

88f5bad

Revert "Added test case"

db4d60d

This reverts commit a79de0d.

Updated the changes

90207ff

Update changes

08a978f

Updated the testcase

d62deda

Commited the changes

db62dd7

Updating code

d93fbe7

Update TestCase

1b608b5

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 23, 2025

Code Update

6f7534f

MartyIX reviewed Apr 23, 2025

View reviewed changes

jsuarezruiz added platform/windows area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing labels Apr 23, 2025

jsuarezruiz reviewed Apr 23, 2025

View reviewed changes

HarishwaranVijayakumar added 3 commits April 24, 2025 16:57

Modify TestCase

e05ce14

TestCase Updation

6f9535a

Code update

4117eda

HarishwaranVijayakumar changed the title ~~[Windows] Fix for ImagePaint is not rendering in View~~ [Windows] Fix for Resize and Downsize function in W2DImage class is not implemented Apr 25, 2025

HarishwaranVijayakumar requested a review from jsuarezruiz April 28, 2025 12:19

HarishwaranVijayakumar added 2 commits May 2, 2025 14:15

Added snapshots

cac6f45

Revert "Added snapshots"

d5e29f3

This reverts commit cac6f45.

NirmalKumarYuvaraj mentioned this pull request May 7, 2025

Pattern Paint is not positioned to 0,0 when X and Y set as 0,0 #29368

Open

jsuarezruiz requested changes May 8, 2025

View reviewed changes

src/Graphics/src/Graphics/Platforms/Windows/PlatformImage.cs Outdated Show resolved Hide resolved

Refactor code

08c5e35

jsuarezruiz approved these changes Jun 9, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current June 9, 2025 19:22

PureWeen merged commit 5442a5e into dotnet:inflight/current Jun 9, 2025
79 of 81 checks passed

HarishwaranVijayakumar mentioned this pull request Jun 12, 2025

FillRectangle with SetFillImage only works on Android #29900

Open

sheiksyedm mentioned this pull request Jun 12, 2025

Multiple bugs in Microsoft.Maui.Graphics.IImage platform specific implementations #21886

Open

This was referenced Jun 12, 2025

[Android, iOS] Fix for the Resize method does not dispose the original image, even when disposeOriginal is set to true #29936

Merged

[iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView #30007

Merged

PureWeen mentioned this pull request Jun 20, 2025

[2025/06/16] Candidate - In Flight Branch #29886

Merged

PureWeen added this to the .NET 9 SR9 milestone Jun 23, 2025

github-actions bot locked and limited conversation to collaborators Jul 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Windows] Implemented the Resize and Downsize functions in the W2DImage class #29138

[Windows] Implemented the Resize and Downsize functions in the W2DImage class #29138

HarishwaranVijayakumar commented Apr 23, 2025 •

edited

Loading

Uh oh!

MartyIX Apr 23, 2025

Uh oh!

jsuarezruiz Apr 23, 2025

Uh oh!

HarishwaranVijayakumar Apr 25, 2025

Uh oh!

jsuarezruiz Apr 23, 2025

Uh oh!

jsuarezruiz Apr 23, 2025

Uh oh!

jsuarezruiz commented Apr 25, 2025

Uh oh!

azure-pipelines bot commented Apr 25, 2025

Uh oh!

jsuarezruiz commented May 6, 2025

Uh oh!

azure-pipelines bot commented May 6, 2025

Uh oh!

Uh oh!

jsuarezruiz commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Windows] Implemented the Resize and Downsize functions in the W2DImage class #29138

[Windows] Implemented the Resize and Downsize functions in the W2DImage class #29138

Conversation

HarishwaranVijayakumar commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause of the issue

Description of Change

Issues Fixed

Tested the behaviour in the following platforms

Output

Uh oh!

MartyIX Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

HarishwaranVijayakumar Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Apr 25, 2025

Uh oh!

azure-pipelines bot commented Apr 25, 2025

Uh oh!

jsuarezruiz commented May 6, 2025

Uh oh!

azure-pipelines bot commented May 6, 2025

Uh oh!

Uh oh!

jsuarezruiz commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HarishwaranVijayakumar commented Apr 23, 2025 •

edited

Loading