KEMBAR78
[android] Fallback to default icons in SearchHandler by aheubusch · Pull Request #25067 · dotnet/maui · GitHub
Skip to content

Conversation

@aheubusch
Copy link
Contributor

Description of Change

On Android the SearchHandler SearchIcon and ClearIcon are not visible unless explicit specified. It seems this used to work 3 years ago.
If I did my research right this behavior got removed between these commits.
bbca522
f3d24c1
f84d447

On iOS both icons are visible if not specified.

Issues Fixed

Couldnt find any.

Screenshots:
Before

After

@aheubusch aheubusch requested a review from a team as a code owner October 3, 2024 08:16
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 3, 2024
@dotnet-policy-service
Copy link
Contributor

Hey there @aheubusch! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@aheubusch
Copy link
Contributor Author

@dotnet-policy-service agree

@rmarinho
Copy link
Member

rmarinho commented Oct 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz added platform/android area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Oct 4, 2024
If no QueryIcon / ClearIcon is specified use default icon.
@aheubusch aheubusch requested a review from jsuarezruiz October 16, 2024 14:46
@aheubusch aheubusch closed this Oct 23, 2024
@aheubusch aheubusch deleted the patch-1 branch October 23, 2024 08:21
@aheubusch aheubusch restored the patch-1 branch October 23, 2024 08:33
@aheubusch aheubusch reopened this Oct 23, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current June 13, 2025 12:08
@PureWeen PureWeen merged commit 462a7e9 into dotnet:inflight/current Jun 13, 2025
109 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen pushed a commit that referenced this pull request Jun 21, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen pushed a commit that referenced this pull request Jun 25, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen pushed a commit that referenced this pull request Jun 25, 2025
If no QueryIcon / ClearIcon is specified use default icon.
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
If no QueryIcon / ClearIcon is specified use default icon.
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen pushed a commit that referenced this pull request Jun 27, 2025
If no QueryIcon / ClearIcon is specified use default icon.
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen pushed a commit that referenced this pull request Jun 27, 2025
If no QueryIcon / ClearIcon is specified use default icon.
PureWeen added a commit that referenced this pull request Jun 28, 2025
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes - Inflight/Candidate Branch

## What's Changed

### MAUI Product Fixes
* [iOS] CarouselView with CarouselViewHandler2 make app crash when
Loop="False" and user scroll to the last position - fixes #26863 by
@kubaflo in #26868
* Fixes Setting BackgroundColor to null does not actually changes
BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in
#22917
* Fixed the picker title's color - fixes #16737 by @kubaflo in
#23075
* [android] Fallback to default icons in SearchHandler by @aheubusch in
#25067
* ScrollView's Background on iOS - fixes #24016 by @kubaflo in
#25541
* [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in
GraphicsView - fixes #29461 by @prakashKannanSf3972 in
#29895
* Optimize converters for GridLength, ColumnDefinition, and
RowDefinition - performance improvement by @emiller in
#20048
* Add defensive IsAlive check to Android ViewExtensions.OnUnloaded -
fixes #28051 by @jfversluis in #29934
* [Windows] Fixed runtime update issue for SearchBar PlaceholderColor
and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in
#29965
* Weak subscription to CanExecuteChange events - fixes #16124 by
@sneumaier in #29837
* [iOS, Mac] Fix for downsized image retaining original dimensions in
GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in
#30007
* [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739,
#8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in
#29068
* Fix CV1 GridItemsLayout centering single item AND Fix Empty view not
resizing when bounds change - fixes #29595, #29634 by @albyrock87 in
#29639

### Testing
* [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853
in #29803
* [Testing] Feature matrix UITest Cases for BoxView Control by
@HarishKumarSF4517 in #29808
* [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by
@bhavanesh2001 in #29896
* [Testing] Add Validation Test For Issue28051 On Android by
@prakashKannanSf3972 in #30026
* [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate
by @HarishKumarSF4517 in #30136

### Dependency Updates
* Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in
#29915

### Housekeeping
* [housekeeping] Update namespaces in HostApp and Shared tests projects
by @bhavanesh2001 in #29904
* Update SetterSpecificity.cs Remove Extra Line From Bad Merge by
@sneumaier in #29987
* Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali
in #30023
* Revert "Fixes Setting BackgroundColor to null does not actually
changes BackgroundColor #22914 (#22917)" by @mattleibow in
#30031
* [create-pull-request] automated change by @github-actions[bot] in
#30019
* [create-pull-request] automated change by @github-actions[bot] in
#30043
* [create-pull-request] automated change by @github-actions[bot] in
#30078
* Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in
#30124

## New Contributors
* @albyrock87 made their first contribution in
#29639
* @SyedAbdulAzeemSF4852 made their first contribution in
#30007
* @emiller made their first contribution in
#20048
* @jgonzalez-gft made their first contribution in
#22917
* @aheubusch made their first contribution in
#25067

**Full Changelog**:
https://github.com/dotnet/maui/compare/main..inflight/candidate
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants