[Windows] Fixed runtime update issue for SearchBar PlaceholderColor and BackgroundColor #29965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that runtime updates to a SearchBar’s PlaceholderColor and BackgroundColor on Windows are immediately applied by invoking RefreshThemeResources() after modifying the resource dictionary.
- Added a new overload of
UpdateColorsthat accepts the control and callsRefreshThemeResources() - Updated
UpdateBackgroundandUpdatePlaceholderColorto use the newUpdateColorssignature - Standardized null checks and added braces for clarity; refined
UpdateMaxLengthlogic to always set read-only state
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/Platform/Windows/SearchBarExtensions.cs | Refactored color update helpers, ensured theme resources are refreshed after resource updates |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29962.cs | Added a UI test that taps the button and verifies placeholder and background colors at runtime |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29962.cs | Added a sample page with a SearchBar and button to change colors, exposing ColorChangeButton ID |
Comments suppressed due to low confidence (4)
src/Core/src/Platform/Windows/SearchBarExtensions.cs:10
- The
_backgroundColorKeysfield was previously private; consider restoring theprivatemodifier to limit its visibility and follow encapsulation best practices.
static readonly string[] _backgroundColorKeys =
src/Core/src/Platform/Windows/SearchBarExtensions.cs:38
- The
_placeholderForegroundColorKeysfield is now internal; it should remain private unless access from other classes within the assembly is required.
static readonly string[] _placeholderForegroundColorKeys =
src/Core/src/Platform/Windows/SearchBarExtensions.cs:56
- Similarly,
_foregroundColorKeysshould be declaredprivate static readonlyto restrict its scope to this class.
static readonly string[] _foregroundColorKeys =
src/Core/src/Platform/Windows/SearchBarExtensions.cs:82
- The
UpdateColorshelper method lost its visibility modifier—consider making itprivate staticto avoid unintended external usage.
static void UpdateColors(AutoSuggestBox platformControl, string[] keys, Brush? brush)
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tamilarasan-Paranthaman
force-pushed
the
SearchBar-Color-Issues
branch
from
b426f2e to
0bd0aed
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
Jun 16, 2025
PureWeen
pushed a commit
that referenced
this pull request
Jun 21, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
PureWeen
added a commit
that referenced
this pull request
Jun 28, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - Inflight/Candidate Branch ## What's Changed ### MAUI Product Fixes * [iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fixes #26863 by @kubaflo in #26868 * Fixes Setting BackgroundColor to null does not actually changes BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in #22917 * Fixed the picker title's color - fixes #16737 by @kubaflo in #23075 * [android] Fallback to default icons in SearchHandler by @aheubusch in #25067 * ScrollView's Background on iOS - fixes #24016 by @kubaflo in #25541 * [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in GraphicsView - fixes #29461 by @prakashKannanSf3972 in #29895 * Optimize converters for GridLength, ColumnDefinition, and RowDefinition - performance improvement by @emiller in #20048 * Add defensive IsAlive check to Android ViewExtensions.OnUnloaded - fixes #28051 by @jfversluis in #29934 * [Windows] Fixed runtime update issue for SearchBar PlaceholderColor and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in #29965 * Weak subscription to CanExecuteChange events - fixes #16124 by @sneumaier in #29837 * [iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in #30007 * [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739, #8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in #29068 * Fix CV1 GridItemsLayout centering single item AND Fix Empty view not resizing when bounds change - fixes #29595, #29634 by @albyrock87 in #29639 ### Testing * [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853 in #29803 * [Testing] Feature matrix UITest Cases for BoxView Control by @HarishKumarSF4517 in #29808 * [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by @bhavanesh2001 in #29896 * [Testing] Add Validation Test For Issue28051 On Android by @prakashKannanSf3972 in #30026 * [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate by @HarishKumarSF4517 in #30136 ### Dependency Updates * Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in #29915 ### Housekeeping * [housekeeping] Update namespaces in HostApp and Shared tests projects by @bhavanesh2001 in #29904 * Update SetterSpecificity.cs Remove Extra Line From Bad Merge by @sneumaier in #29987 * Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali in #30023 * Revert "Fixes Setting BackgroundColor to null does not actually changes BackgroundColor #22914 (#22917)" by @mattleibow in #30031 * [create-pull-request] automated change by @github-actions[bot] in #30019 * [create-pull-request] automated change by @github-actions[bot] in #30043 * [create-pull-request] automated change by @github-actions[bot] in #30078 * Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in #30124 ## New Contributors * @albyrock87 made their first contribution in #29639 * @SyedAbdulAzeemSF4852 made their first contribution in #30007 * @emiller made their first contribution in #20048 * @jgonzalez-gft made their first contribution in #22917 * @aheubusch made their first contribution in #25067 **Full Changelog**: https://github.com/dotnet/maui/compare/main..inflight/candidate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #29962
Tested the behaviour in the following platforms
Screenshot
Before-Fix-SB.mp4
After-Fix-SB.mp4