[iOS] Fix memory leak in CarouselViewHandler2 #29719
Merged
+188
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavanesh2001
commented
May 28, 2025
|
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/ios
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
reviewed
May 29, 2025
rmarinho
previously approved these changes
May 29, 2025
rmarinho
previously approved these changes
May 29, 2025
|
The CarouselView tests failed on CI due to the changes introduced by this PR. Setting the FlowDirection to either LeftToRight or RightToLeft on CarouselView is now failing. |
|
@sheiksyedm Thanks for letting me know. #29784 should fix the failures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
CarouselViewHandler2sets aVisibleItemsInvalidationHandleron theNSCollectionLayoutSectionduring layout construction. This handler captures strong references toVirtualViewandController, causing a memory leak.Updated the handler to use WeakReference's. Moved Layout creation to
LayoutFacotryIssues Fixed
Fixes #29677