KEMBAR78
Fix CarouselView Feature Matrix tests failing on main by bhavanesh2001 · Pull Request #29784 · dotnet/maui · GitHub
Skip to content

Conversation

bhavanesh2001
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

An extra unwanted null check was added with #29719 . Which is causing feature matrix tests to fail.

Screenshot 2025-06-02 at 8 18 50 PM

Issues Fixed

Fixes #

@bhavanesh2001 bhavanesh2001 requested a review from a team as a code owner June 2, 2025 14:52
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 2, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@PureWeen
Copy link
Member

PureWeen commented Jun 2, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR8 milestone Jun 2, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Jun 2, 2025
@jsuarezruiz jsuarezruiz added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Jun 2, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Jun 2, 2025
@rmarinho rmarinho merged commit a575a57 into dotnet:main Jun 2, 2025
123 of 129 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Jun 2, 2025
github-actions bot pushed a commit to bhavanesh2001/maui that referenced this pull request Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants