Fixed the RealParent Warning shown issue #30156

Ahamed-Ali · 2025-06-24T07:00:36Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause of the issue

When navigating from a first page (with a button) to a second page containing controls like Image, Label, or Border, a warning occurs if properties such as StrokeShape, Image.Source, or Label.FormattedText are bound to values from a ViewModel that was implemented as a static (singleton) instance.

For example, if a StrokeShape is created and stored statically, it is instantiated only once during the first navigation. On subsequent navigations, the same instance is reused. Since elements like StrokeShape maintain a reference to their previous parent, reusing the same instance causes conflicts and triggers warnings due to improper parent-child relationships.

Description of Change

Accesses RealParent in a safe way to prevent warnings from occurring when the parent has already been removed or collected.

Issues Fixed

Fixes #23050

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix
WithWarnings.mov	NoWarnings.mov

dotnet-policy-service · 2025-06-24T07:00:52Z

Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR fixes warnings caused by reusing element instances across navigation by safely accessing RealParent and avoiding invalid parent references.

Introduces GetRealParent method with optional warning suppression
Encapsulates and preserves the public RealParent API via the new method
Updates SetParent to use the non-logging parent lookup

Comments suppressed due to low confidence (1)

src/Controls/src/Core/Element/Element.cs:335

Add unit tests to cover GetRealParent behavior in both warning and non-warning modes, ensuring that old parents are handled correctly and no warnings are emitted when suppressed.

		WeakReference<Element> _realParent;

src/Controls/src/Core/Element/Element.cs

Copilot · 2025-06-24T07:53:18Z

src/Controls/src/Core/Element/Element.cs

 			if (_parentOverride == null)
 			{
-				OnParentChangingCore(Parent, value);
+				OnParentChangingCore(ParentOverride ?? GetRealParent(false), value);


Instead of calling GetRealParent(false) again, reuse the realParent local variable for the previous parent to avoid redundant method calls and ensure consistent state.

Suggested change

OnParentChangingCore(ParentOverride ?? GetRealParent(false), value);

OnParentChangingCore(ParentOverride ?? realParent, value);

Optimized the fix based on suggestion

MartyIX · 2025-06-24T08:14:14Z

src/Controls/src/Core/Element/Element.cs

-
 				return null;
 			}
+			if (_realParent.TryGetTarget(out var parent))


Isn't it the safest to store

var realParent = _realParent; if (realParent is null) { return null;} if (...) ...

?

I believe that if (_realParent.TryGetTarget(out var parent)) can still lead to NRE because _realParent can become null at any moment.

src/Controls/src/Core/Element/Element.cs

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

…ase on PR #30156 with improvements Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

…0156 with enhancements Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

PureWeen

Can you review the changes here as well #30291 and see if the test is relevant.
Just pull over whatever changes seem correct into this PR

Copilot made a good point about nulling out the weakref as well since that's going to lead to repetative logging messages when retrieving the parent

Ahamed-Ali · 2025-06-30T10:26:53Z

Can you review the changes here as well #30291 and see if the test is relevant. Just pull over whatever changes seem correct into this PR

Copilot made a good point about nulling out the weakref as well since that's going to lead to repetative logging messages when retrieving the parent

I have included the valid changes from the Copilot PR into this PR, specifically addressing the clearing of the weak reference when the target object has been collected.

Additionally, I have included the tests from the Copilot PR. While the test passes both with and without the fix—since the warning issue, based on investigation, occurs in a static element during random multiple navigations—the test is still valid for verifying the RealParent. Therefore, I have included it. @PureWeen

src/Controls/src/Core/Element/Element.cs

src/Controls/tests/Core.UnitTests/ElementTests.cs

src/Controls/src/Core/Element/Element.cs

Changes made

* Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly

* Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Remove .NET 8 specific code for templates (#30342) * [Catalyst] Fix Scrollbar does not align with FlowDirection change in ScrollView (#30241) * fix added * Revert "fix added" This reverts commit 138797f. * fix added * fix updated * [Android] Fix for OnSizeAllocated is not reported for Android AppShell Flyout content. (#30069) * fix-22045 - Made changes on Android ShellFlyout sizing by adding OnDrawerOpened event and updating Content so OnSizeAllocated is called with correct values when drawer opens. * fix-22045- Set the contentview frame value when the FlyoutView layout change. * fix-22045- Changes committed. * Permissions (BT & WiFi): don't add AccessFineLocation to required permissions if NeverForLocation flag is present (#20874) * otherwise the permission-status will be 'denied' if AccessFineLocation is in the manifest, but denied at runtime (even if it is not strictly required) * Fixed the RealParent Warning shown issue (#30156) * Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly * [iOS/MacCatalyst] Fix: Setting SelectedItem Programmatically and Then Immediately Setting ItemsSource to Null Causes a Crash (#29940) * Re-evaluate indexpaths in PerformBatchUpdates * Add UI test * update test * bring back null check * add a check to see if ItemsSource is disposed * [Windows] Fixed StackLayout crashes on Windows with HeightRequest as 0 (#29926) * Fixed StackLayout crashes on Windows with HeightRequest 0, padding, and opposing alignment. * Included test case for Vertical StackLayout * Updated label content * [Windows] Fixed CanvasDrawingSession Exception on Clipping Image (#30028) * [Windows] Fixed CanvasDrawingSession Exception * Update in description label * Updated Suggested Changes * [Testing] Feature matrix UITest Cases for ScrollView Control (#30188) * Added Feature Matrix for ScrollView * Updated changes * Changes updated * Modified the test cases * Modified UI * Added snapshots * Added images * Modified Test Case * Added images * Resaved images * [Testing] Feature Matrix UITest Cases for TimePicker Control (#30271) * modified UI and test cases * updated test cases * added new test cases * updated test cases * added android and iOS snapshots * updated format * updated flow direction code * added mac and windows snapshots * updated iOS snapshots * [Catalyst] Adding and Removing ContextMenus currently does not work - fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs * Fix for TapGestureRecognizer ButtonMask always return 0 (#30372) * Fix for TapGesture ButtonMask * Added TestCase * Update Testcase * Modified Testcase * fix extention typo (#30461) * fix some incorrect casting using `as` (#30459) if the type is known then a direct cast should be used instead of an as. since, in the case where the assumption is wrong, then it is better to get a cast exception instead of a null ref exception. basically if code uses `as` and does not check for null when that variable is used, then it is likely problematic code. * [Testing] Feature Matrix UITest Cases for SearchBar Control (#30398) * added test cases * added snapshots * comment added * snapshot added * changed method name * [Testing] Feature Matrix UITest Cases for DatePicker Control (#30159) * added test cases * added new test cases * removed test cases * updated test cases * updated test cases * changes in test case * added new event * updated test cases * added culture test cases * added snapshots * added the failing condition * modified test case * added new test case code * added mac and windows snapshots * [create-pull-request] automated change (#30591) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # Conflicts: # src/Compatibility/Core/src/Tizen/Forms.cs * [Testing] Add UITest for Issue30147 on iOS (#30506) * fix added * Revert "fix added" This reverts commit 138797f. * test case added * test sample modified * test sample updated * affected platform changed * sample changes added * [Android] Fix for Search Handler visual and functional bug in subtabs (#30467) * fix-21119-Made changes to ShellToolbarTracker.cs to prevent search handler stacking on Android Shell tab navigation by removing existing menu items before adding new ones. * fix-21119-Testcase and test snapshot added. * fix-21119-Updated code changes. Also added Mac and Windows snapshots. * [Windows] Fixed the Pasted Password Becomes Visible When IsPassword Is Enabled (#30353) * Fixed the masked text issue of same value pasted into the textbox field * Added the test for verifying the masked text * [create-pull-request] automated change (#30700) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False (#30755) * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False * Updated PlatformTouchGraphicsView * Updated test sample * Fix duplicate app icon resizing (#30920) Possibly helps with #30900 * Addressed the feedbacks * Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Addressed the feedbacks --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: TamilarasanSF4853 <tamilarasan.velu@syncfusion.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: HarishwaranVijayakumar <harishwaran.vijayakumar@syncfusion.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Jeremy Powell <47993233+jeremy-visionaid@users.noreply.github.com>

* Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly

* Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Remove .NET 8 specific code for templates (#30342) * [Catalyst] Fix Scrollbar does not align with FlowDirection change in ScrollView (#30241) * fix added * Revert "fix added" This reverts commit 138797f. * fix added * fix updated * [Android] Fix for OnSizeAllocated is not reported for Android AppShell Flyout content. (#30069) * fix-22045 - Made changes on Android ShellFlyout sizing by adding OnDrawerOpened event and updating Content so OnSizeAllocated is called with correct values when drawer opens. * fix-22045- Set the contentview frame value when the FlyoutView layout change. * fix-22045- Changes committed. * Permissions (BT & WiFi): don't add AccessFineLocation to required permissions if NeverForLocation flag is present (#20874) * otherwise the permission-status will be 'denied' if AccessFineLocation is in the manifest, but denied at runtime (even if it is not strictly required) * Fixed the RealParent Warning shown issue (#30156) * Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly * [iOS/MacCatalyst] Fix: Setting SelectedItem Programmatically and Then Immediately Setting ItemsSource to Null Causes a Crash (#29940) * Re-evaluate indexpaths in PerformBatchUpdates * Add UI test * update test * bring back null check * add a check to see if ItemsSource is disposed * [Windows] Fixed StackLayout crashes on Windows with HeightRequest as 0 (#29926) * Fixed StackLayout crashes on Windows with HeightRequest 0, padding, and opposing alignment. * Included test case for Vertical StackLayout * Updated label content * [Windows] Fixed CanvasDrawingSession Exception on Clipping Image (#30028) * [Windows] Fixed CanvasDrawingSession Exception * Update in description label * Updated Suggested Changes * [Testing] Feature matrix UITest Cases for ScrollView Control (#30188) * Added Feature Matrix for ScrollView * Updated changes * Changes updated * Modified the test cases * Modified UI * Added snapshots * Added images * Modified Test Case * Added images * Resaved images * [Testing] Feature Matrix UITest Cases for TimePicker Control (#30271) * modified UI and test cases * updated test cases * added new test cases * updated test cases * added android and iOS snapshots * updated format * updated flow direction code * added mac and windows snapshots * updated iOS snapshots * [Catalyst] Adding and Removing ContextMenus currently does not work - fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs * Fix for TapGestureRecognizer ButtonMask always return 0 (#30372) * Fix for TapGesture ButtonMask * Added TestCase * Update Testcase * Modified Testcase * fix extention typo (#30461) * fix some incorrect casting using `as` (#30459) if the type is known then a direct cast should be used instead of an as. since, in the case where the assumption is wrong, then it is better to get a cast exception instead of a null ref exception. basically if code uses `as` and does not check for null when that variable is used, then it is likely problematic code. * [Testing] Feature Matrix UITest Cases for SearchBar Control (#30398) * added test cases * added snapshots * comment added * snapshot added * changed method name * [Testing] Feature Matrix UITest Cases for DatePicker Control (#30159) * added test cases * added new test cases * removed test cases * updated test cases * updated test cases * changes in test case * added new event * updated test cases * added culture test cases * added snapshots * added the failing condition * modified test case * added new test case code * added mac and windows snapshots * [create-pull-request] automated change (#30591) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # Conflicts: # src/Compatibility/Core/src/Tizen/Forms.cs * [Testing] Add UITest for Issue30147 on iOS (#30506) * fix added * Revert "fix added" This reverts commit 138797f. * test case added * test sample modified * test sample updated * affected platform changed * sample changes added * [Android] Fix for Search Handler visual and functional bug in subtabs (#30467) * fix-21119-Made changes to ShellToolbarTracker.cs to prevent search handler stacking on Android Shell tab navigation by removing existing menu items before adding new ones. * fix-21119-Testcase and test snapshot added. * fix-21119-Updated code changes. Also added Mac and Windows snapshots. * [Windows] Fixed the Pasted Password Becomes Visible When IsPassword Is Enabled (#30353) * Fixed the masked text issue of same value pasted into the textbox field * Added the test for verifying the masked text * [create-pull-request] automated change (#30700) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False (#30755) * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False * Updated PlatformTouchGraphicsView * Updated test sample * Fix duplicate app icon resizing (#30920) Possibly helps with #30900 * Addressed the feedbacks * Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Addressed the feedbacks --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: TamilarasanSF4853 <tamilarasan.velu@syncfusion.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: HarishwaranVijayakumar <harishwaran.vijayakumar@syncfusion.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Jeremy Powell <47993233+jeremy-visionaid@users.noreply.github.com>

* Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly

Ahamed-Ali added 2 commits June 24, 2025 11:35

Safe Get of RealParent to avoid warnings

73d3900

Optimized the fix

5d4aa97

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jun 24, 2025

Make it as default private

803d1fb

Ahamed-Ali marked this pull request as ready for review June 24, 2025 07:52

Copilot AI review requested due to automatic review settings June 24, 2025 07:52

Ahamed-Ali requested a review from a team as a code owner June 24, 2025 07:52

Ahamed-Ali requested review from mattleibow and rmarinho June 24, 2025 07:52

Copilot AI reviewed Jun 24, 2025

View reviewed changes

Optimized the fix

6f023a7

MartyIX reviewed Jun 24, 2025

View reviewed changes

PureWeen added this to the .NET 9 SR9 milestone Jun 24, 2025

PureWeen added this to MAUI SDK Ongoing Jun 24, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Jun 24, 2025

PureWeen added the p/0 Work that we can't release without label Jun 24, 2025

PureWeen requested changes Jun 27, 2025

View reviewed changes

src/Controls/src/Core/Element/Element.cs Outdated Show resolved Hide resolved

github-project-automation bot moved this from Todo to Changes Requested in MAUI SDK Ongoing Jun 27, 2025

PureWeen mentioned this pull request Jun 28, 2025

Fix RealParent garbage collection warning to reduce noise in production apps #30291

Closed

Copilot AI added a commit that referenced this pull request Jun 28, 2025

Remove DEBUG conditional and incorporate PR #30156 fixes

1c53139

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

Copilot AI added a commit that referenced this pull request Jun 28, 2025

Start fresh implementation following updated copilot instructions - b…

845fb06

…ase on PR #30156 with improvements Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

Copilot AI added a commit that referenced this pull request Jun 28, 2025

Start fresh implementation: Fix RealParent GC warnings based on PR #3…

a8e73ba

…0156 with enhancements Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

PureWeen requested changes Jun 29, 2025

View reviewed changes

Modified the fix and added test

9f2fc04

PureWeen requested changes Jun 30, 2025

View reviewed changes

src/Controls/src/Core/Element/Element.cs Outdated Show resolved Hide resolved

jsuarezruiz previously requested changes Jul 1, 2025

View reviewed changes

src/Controls/src/Core/Element/Element.cs Outdated Show resolved Hide resolved

src/Controls/src/Core/Element/Element.cs Outdated Show resolved Hide resolved

src/Controls/tests/Core.UnitTests/ElementTests.cs Show resolved Hide resolved

Modified the fix based on concern and added test

dc0535e

unwanted spacing

6b0013c

PureWeen requested changes Jul 1, 2025

View reviewed changes

src/Controls/src/Core/Element/Element.cs Outdated Show resolved Hide resolved

Replaced the Parent property directly

e546275

PureWeen approved these changes Jul 2, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current July 2, 2025 16:15

PureWeen merged commit 249a31d into dotnet:inflight/current Jul 2, 2025
4 checks passed

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Jul 2, 2025

PureWeen mentioned this pull request Jul 18, 2025

July 21st, 2025 Candidate #30696

Merged

github-actions bot locked and limited conversation to collaborators Aug 2, 2025

PureWeen added the area-architecture Issues with code structure, SDK structure, implementation details label Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed the RealParent Warning shown issue #30156

Fixed the RealParent Warning shown issue #30156

Uh oh!

Ahamed-Ali commented Jun 24, 2025

Uh oh!

dotnet-policy-service bot commented Jun 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jun 24, 2025

Uh oh!

Ahamed-Ali Jun 24, 2025

Uh oh!

MartyIX Jun 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

PureWeen left a comment •

edited

Loading

Uh oh!

Ahamed-Ali commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	OnParentChangingCore(ParentOverride ?? GetRealParent(false), value);
	OnParentChangingCore(ParentOverride ?? realParent, value);

Fixed the RealParent Warning shown issue #30156

Fixed the RealParent Warning shown issue #30156

Uh oh!

Conversation

Ahamed-Ali commented Jun 24, 2025

Root Cause of the issue

Description of Change

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented Jun 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

MartyIX Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PureWeen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MartyIX Jun 24, 2025 •

edited

Loading

PureWeen left a comment •

edited

Loading