[Catalyst] Adding and Removing ContextMenus currently does not work - fix #30307

kubaflo · 2025-06-29T23:10:28Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Since context menus with webView don't function anyway (#30308), I think it's safe to add this line of code that enables runtime changes to menu items

Issues Fixed

Fixes #9359

public MainPage()
{
	var menuFlyout = new MenuFlyout();

	var button = new Button
	{
		Text = "Click me to add new item to me",
		AutomationId = "myButton",
		Command = new Command(() => menuFlyout.Add(new MenuFlyoutItem { Text = $"New Item {menuFlyout.Count + 1}" })),
	};
	
	FlyoutBase.SetContextFlyout(button, menuFlyout);
	Content = new StackLayout { Children = { button } };
}

Screen.Recording.2025-06-30.at.01.19.46.mov

Copilot

Pull Request Overview

This PR addresses an issue with context menu behavior on iOS by ensuring that the current handler is disconnected before a new one is created.

Disconnects any existing context menu handler before assigning a new one
Fixes the runtime update problem with context menus as observed in issue #9359

src/Core/src/Platform/iOS/MauiUIContextMenuInteraction.cs

jsuarezruiz · 2025-06-30T06:10:42Z

/azp run

azure-pipelines · 2025-06-30T06:11:06Z

Azure Pipelines successfully started running 3 pipeline(s).

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

* Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Remove .NET 8 specific code for templates (#30342) * [Catalyst] Fix Scrollbar does not align with FlowDirection change in ScrollView (#30241) * fix added * Revert "fix added" This reverts commit 138797f. * fix added * fix updated * [Android] Fix for OnSizeAllocated is not reported for Android AppShell Flyout content. (#30069) * fix-22045 - Made changes on Android ShellFlyout sizing by adding OnDrawerOpened event and updating Content so OnSizeAllocated is called with correct values when drawer opens. * fix-22045- Set the contentview frame value when the FlyoutView layout change. * fix-22045- Changes committed. * Permissions (BT & WiFi): don't add AccessFineLocation to required permissions if NeverForLocation flag is present (#20874) * otherwise the permission-status will be 'denied' if AccessFineLocation is in the manifest, but denied at runtime (even if it is not strictly required) * Fixed the RealParent Warning shown issue (#30156) * Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly * [iOS/MacCatalyst] Fix: Setting SelectedItem Programmatically and Then Immediately Setting ItemsSource to Null Causes a Crash (#29940) * Re-evaluate indexpaths in PerformBatchUpdates * Add UI test * update test * bring back null check * add a check to see if ItemsSource is disposed * [Windows] Fixed StackLayout crashes on Windows with HeightRequest as 0 (#29926) * Fixed StackLayout crashes on Windows with HeightRequest 0, padding, and opposing alignment. * Included test case for Vertical StackLayout * Updated label content * [Windows] Fixed CanvasDrawingSession Exception on Clipping Image (#30028) * [Windows] Fixed CanvasDrawingSession Exception * Update in description label * Updated Suggested Changes * [Testing] Feature matrix UITest Cases for ScrollView Control (#30188) * Added Feature Matrix for ScrollView * Updated changes * Changes updated * Modified the test cases * Modified UI * Added snapshots * Added images * Modified Test Case * Added images * Resaved images * [Testing] Feature Matrix UITest Cases for TimePicker Control (#30271) * modified UI and test cases * updated test cases * added new test cases * updated test cases * added android and iOS snapshots * updated format * updated flow direction code * added mac and windows snapshots * updated iOS snapshots * [Catalyst] Adding and Removing ContextMenus currently does not work - fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs * Fix for TapGestureRecognizer ButtonMask always return 0 (#30372) * Fix for TapGesture ButtonMask * Added TestCase * Update Testcase * Modified Testcase * fix extention typo (#30461) * fix some incorrect casting using `as` (#30459) if the type is known then a direct cast should be used instead of an as. since, in the case where the assumption is wrong, then it is better to get a cast exception instead of a null ref exception. basically if code uses `as` and does not check for null when that variable is used, then it is likely problematic code. * [Testing] Feature Matrix UITest Cases for SearchBar Control (#30398) * added test cases * added snapshots * comment added * snapshot added * changed method name * [Testing] Feature Matrix UITest Cases for DatePicker Control (#30159) * added test cases * added new test cases * removed test cases * updated test cases * updated test cases * changes in test case * added new event * updated test cases * added culture test cases * added snapshots * added the failing condition * modified test case * added new test case code * added mac and windows snapshots * [create-pull-request] automated change (#30591) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # Conflicts: # src/Compatibility/Core/src/Tizen/Forms.cs * [Testing] Add UITest for Issue30147 on iOS (#30506) * fix added * Revert "fix added" This reverts commit 138797f. * test case added * test sample modified * test sample updated * affected platform changed * sample changes added * [Android] Fix for Search Handler visual and functional bug in subtabs (#30467) * fix-21119-Made changes to ShellToolbarTracker.cs to prevent search handler stacking on Android Shell tab navigation by removing existing menu items before adding new ones. * fix-21119-Testcase and test snapshot added. * fix-21119-Updated code changes. Also added Mac and Windows snapshots. * [Windows] Fixed the Pasted Password Becomes Visible When IsPassword Is Enabled (#30353) * Fixed the masked text issue of same value pasted into the textbox field * Added the test for verifying the masked text * [create-pull-request] automated change (#30700) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False (#30755) * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False * Updated PlatformTouchGraphicsView * Updated test sample * Fix duplicate app icon resizing (#30920) Possibly helps with #30900 * Addressed the feedbacks * Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Addressed the feedbacks --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: TamilarasanSF4853 <tamilarasan.velu@syncfusion.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: HarishwaranVijayakumar <harishwaran.vijayakumar@syncfusion.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Jeremy Powell <47993233+jeremy-visionaid@users.noreply.github.com>

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

* Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Remove .NET 8 specific code for templates (#30342) * [Catalyst] Fix Scrollbar does not align with FlowDirection change in ScrollView (#30241) * fix added * Revert "fix added" This reverts commit 138797f. * fix added * fix updated * [Android] Fix for OnSizeAllocated is not reported for Android AppShell Flyout content. (#30069) * fix-22045 - Made changes on Android ShellFlyout sizing by adding OnDrawerOpened event and updating Content so OnSizeAllocated is called with correct values when drawer opens. * fix-22045- Set the contentview frame value when the FlyoutView layout change. * fix-22045- Changes committed. * Permissions (BT & WiFi): don't add AccessFineLocation to required permissions if NeverForLocation flag is present (#20874) * otherwise the permission-status will be 'denied' if AccessFineLocation is in the manifest, but denied at runtime (even if it is not strictly required) * Fixed the RealParent Warning shown issue (#30156) * Safe Get of RealParent to avoid warnings * Optimized the fix * Make it as default private * Optimized the fix * Modified the fix and added test * Modified the fix based on concern and added test * unwanted spacing * Replaced the Parent property directly * [iOS/MacCatalyst] Fix: Setting SelectedItem Programmatically and Then Immediately Setting ItemsSource to Null Causes a Crash (#29940) * Re-evaluate indexpaths in PerformBatchUpdates * Add UI test * update test * bring back null check * add a check to see if ItemsSource is disposed * [Windows] Fixed StackLayout crashes on Windows with HeightRequest as 0 (#29926) * Fixed StackLayout crashes on Windows with HeightRequest 0, padding, and opposing alignment. * Included test case for Vertical StackLayout * Updated label content * [Windows] Fixed CanvasDrawingSession Exception on Clipping Image (#30028) * [Windows] Fixed CanvasDrawingSession Exception * Update in description label * Updated Suggested Changes * [Testing] Feature matrix UITest Cases for ScrollView Control (#30188) * Added Feature Matrix for ScrollView * Updated changes * Changes updated * Modified the test cases * Modified UI * Added snapshots * Added images * Modified Test Case * Added images * Resaved images * [Testing] Feature Matrix UITest Cases for TimePicker Control (#30271) * modified UI and test cases * updated test cases * added new test cases * updated test cases * added android and iOS snapshots * updated format * updated flow direction code * added mac and windows snapshots * updated iOS snapshots * [Catalyst] Adding and Removing ContextMenus currently does not work - fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs * Fix for TapGestureRecognizer ButtonMask always return 0 (#30372) * Fix for TapGesture ButtonMask * Added TestCase * Update Testcase * Modified Testcase * fix extention typo (#30461) * fix some incorrect casting using `as` (#30459) if the type is known then a direct cast should be used instead of an as. since, in the case where the assumption is wrong, then it is better to get a cast exception instead of a null ref exception. basically if code uses `as` and does not check for null when that variable is used, then it is likely problematic code. * [Testing] Feature Matrix UITest Cases for SearchBar Control (#30398) * added test cases * added snapshots * comment added * snapshot added * changed method name * [Testing] Feature Matrix UITest Cases for DatePicker Control (#30159) * added test cases * added new test cases * removed test cases * updated test cases * updated test cases * changes in test case * added new event * updated test cases * added culture test cases * added snapshots * added the failing condition * modified test case * added new test case code * added mac and windows snapshots * [create-pull-request] automated change (#30591) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # Conflicts: # src/Compatibility/Core/src/Tizen/Forms.cs * [Testing] Add UITest for Issue30147 on iOS (#30506) * fix added * Revert "fix added" This reverts commit 138797f. * test case added * test sample modified * test sample updated * affected platform changed * sample changes added * [Android] Fix for Search Handler visual and functional bug in subtabs (#30467) * fix-21119-Made changes to ShellToolbarTracker.cs to prevent search handler stacking on Android Shell tab navigation by removing existing menu items before adding new ones. * fix-21119-Testcase and test snapshot added. * fix-21119-Updated code changes. Also added Mac and Windows snapshots. * [Windows] Fixed the Pasted Password Becomes Visible When IsPassword Is Enabled (#30353) * Fixed the masked text issue of same value pasted into the textbox field * Added the test for verifying the masked text * [create-pull-request] automated change (#30700) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False (#30755) * Fixed GraphicsView event handlers are triggered even when IsEnabled is set to False * Updated PlatformTouchGraphicsView * Updated test sample * Fix duplicate app icon resizing (#30920) Possibly helps with #30900 * Addressed the feedbacks * Added sample for GraphicsView * Added the feature matrix code * Added the test cases for the GraphicsView * Updated the GraphicsViewFeaturetests * Updated the GraphicsViewViewModel * Addressed the feedbacks * Added the snapshots for Mac and Windows * Addressed the feedbacks --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: TamilarasanSF4853 <tamilarasan.velu@syncfusion.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: HarishwaranVijayakumar <harishwaran.vijayakumar@syncfusion.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Jeremy Powell <47993233+jeremy-visionaid@users.noreply.github.com>

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

Disconnect context flyout handler

82d3ab3

Copilot AI review requested due to automatic review settings June 29, 2025 23:10

kubaflo requested a review from a team as a code owner June 29, 2025 23:10

kubaflo requested review from StephaneDelcroix and jsuarezruiz June 29, 2025 23:10

dotnet-policy-service bot added the community ✨ Community Contribution label Jun 29, 2025

Copilot AI reviewed Jun 29, 2025

View reviewed changes

src/Core/src/Platform/iOS/MauiUIContextMenuInteraction.cs Show resolved Hide resolved

kubaflo self-assigned this Jun 29, 2025

Update MenuFlyoutHandler.iOS.cs

25d2ad0

kubaflo added platform/macos macOS / Mac Catalyst area-controls-contextmenu ContextMenu labels Jun 29, 2025

jfversluis approved these changes Jul 2, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current July 3, 2025 17:17

PureWeen merged commit 1f73480 into dotnet:inflight/current Jul 3, 2025
127 of 129 checks passed

github-actions bot pushed a commit that referenced this pull request Jul 8, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

e9d1cc2

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

github-actions bot pushed a commit that referenced this pull request Jul 9, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

2620f65

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Jul 10, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

2855681

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Jul 15, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

b7c3f79

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Jul 17, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

fe4863c

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen mentioned this pull request Jul 18, 2025

July 21st, 2025 Candidate #30696

Merged

github-actions bot pushed a commit that referenced this pull request Jul 25, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

298026e

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

github-actions bot pushed a commit that referenced this pull request Jul 31, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

70ab682

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Aug 1, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

e6b4d1b

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Aug 1, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

a09ffae

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

PureWeen pushed a commit that referenced this pull request Aug 1, 2025

[Catalyst] Adding and Removing ContextMenus currently does not work -…

2b87456

… fix (#30307) * Disconnect context flyout handler * Update MenuFlyoutHandler.iOS.cs

github-actions bot locked and limited conversation to collaborators Aug 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Catalyst] Adding and Removing ContextMenus currently does not work - fix #30307

[Catalyst] Adding and Removing ContextMenus currently does not work - fix #30307

Uh oh!

kubaflo commented Jun 29, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jsuarezruiz commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Catalyst] Adding and Removing ContextMenus currently does not work - fix #30307

[Catalyst] Adding and Removing ContextMenus currently does not work - fix #30307

Uh oh!

Conversation

kubaflo commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

jsuarezruiz commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kubaflo commented Jun 29, 2025 •

edited

Loading