[Windows] Fixed Image clipping not working #30684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
requested changes
Jul 18, 2025
| VerticalOptions = LayoutOptions.Center | ||
| }; | ||
|
|
||
| var image = new Image |
There was a problem hiding this comment.
Could you extend the sample using a Grid with different columns and clip with different geometries?
There was a problem hiding this comment.
@jsuarezruiz I have made the changes
| var pathGeometry = compositor.CreatePathGeometry(path); | ||
| var geometricClip = compositor.CreateGeometricClip(pathGeometry); | ||
|
|
||
| geometricClip.Offset = new Vector2(-Child.ActualOffset.X, -Child.ActualOffset.Y); |
There was a problem hiding this comment.
Could include a comment explaining why apply these values here?
// Align clip geometry with the child's visual offset to prevent masking misalignment blablabla
There was a problem hiding this comment.
@jsuarezruiz I have added a comment.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Aug 25, 2025
PureWeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
Updated Test Sample with different geometries Updated SnapShots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
RootCause :
The clipping appears misaligned, causing the shape not accurately masks the image as expected.
Description of Change :
Updated the UpdateClip method to adjust the clip's offset using the Child.ActualOffset properties. This ensures that the clipping geometry aligns correctly with the child element's position.
Referrence :
maui/src/Core/src/Platform/Windows/ContentPanel.cs
Line 210 in 6137fa1
Issues Fixed :
Fixes #30440
Tested the behaviour in the following platforms :
Screenshot :