KEMBAR78
fix: a flaky test JsonStreamWriter:testMultiThreadAppendNoSchemaUpdate due to race conditions. by yirutang · Pull Request #721 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and shollyman December 10, 2020 18:17
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Dec 10, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #721 (93a47d2) into master (c30d52e) will increase coverage by 2.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #721      +/-   ##
============================================
+ Coverage     78.68%   81.05%   +2.37%     
- Complexity      662     1000     +338     
============================================
  Files            59       73      +14     
  Lines          3790     5675    +1885     
  Branches        255      463     +208     
============================================
+ Hits           2982     4600    +1618     
- Misses          692      898     +206     
- Partials        116      177      +61     
Impacted Files Coverage Δ Complexity Δ
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.30% <0.00%> (-0.22%) 99.00% <0.00%> (+1.00%) ⬇️
...bigquery/storage/v1beta2/ProtoSchemaConverter.java 96.22% <0.00%> (ø) 10.00% <0.00%> (?%)
...torage/v1beta2/BQTableSchemaToProtoDescriptor.java 98.41% <0.00%> (ø) 8.00% <0.00%> (?%)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 60.34% <0.00%> (ø) 22.00% <0.00%> (?%)
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 77.19% <0.00%> (ø) 12.00% <0.00%> (?%)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 84.88% <0.00%> (ø) 37.00% <0.00%> (?%)
.../bigquery/storage/v1beta2/SchemaCompatibility.java 91.30% <0.00%> (ø) 99.00% <0.00%> (?%)
...igquery/storage/v1beta2/BigQueryWriteSettings.java 25.64% <0.00%> (ø) 5.00% <0.00%> (?%)
...gquery/storage/v1beta2/stub/BigQueryWriteStub.java 14.28% <0.00%> (ø) 1.00% <0.00%> (?%)
...ry/storage/v1beta2/stub/GrpcBigQueryWriteStub.java 95.34% <0.00%> (ø) 14.00% <0.00%> (?%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30d52e...93a47d2. Read the comment docs.

@yirutang yirutang closed this Dec 10, 2020
@yirutang yirutang deleted the fix-test branch December 10, 2020 23:28
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant