KEMBAR78
feat: updates to Write API v1beta2 public interface, migrate to Java microgenerator by yoshi-automation · Pull Request #728 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/3d3baec6-d7e5-4deb-9f9c-ca1af5a70096/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 347036369
Source-Link: googleapis/googleapis@6d65640
PiperOrigin-RevId: 346405446
Source-Link: googleapis/googleapis@abc4306
PiperOrigin-RevId: 345522380
Source-Link: googleapis/googleapis@f8f975c
PiperOrigin-RevId: 345476969
Source-Link: googleapis/googleapis@7be2c82
PiperOrigin-RevId: 345469340
Source-Link: googleapis/googleapis@b53c4d9
PiperOrigin-RevId: 345311069
Source-Link: googleapis/googleapis@e39e42f

Committer: @miraleung
PiperOrigin-RevId: 345311069

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Dec 2 14:17:15 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: e39e42f368d236203a774ee994fcb4d730c33a83
Source-Link: googleapis/googleapis@e39e42f
…ncludes breaking changes to the API, it is fine because the API is not officially launched yet.

PiperOrigin-RevId: 345469340

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Dec 3 09:33:11 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: b53c4d98aab1eae3dac90b37019dede686782f13
Source-Link: googleapis/googleapis@b53c4d9
Committer: @miraleung
PiperOrigin-RevId: 345476969

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Dec 3 10:07:32 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 7be2c821dd88109038c55c89f7dd48f092eeab9d
Source-Link: googleapis/googleapis@7be2c82
…ator

Committer: @miraleung
PiperOrigin-RevId: 345522380

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Dec 3 13:28:07 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: f8f975c7d43904e90d6c5f1684fdb6804400e641
Source-Link: googleapis/googleapis@f8f975c
Committer: @miraleung
PiperOrigin-RevId: 346405446

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Dec 8 14:03:11 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: abc43060f136ce77124754a48f367102e646844a
Source-Link: googleapis/googleapis@abc4306
Committer: @miraleung
PiperOrigin-RevId: 347036369

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Dec 11 11:13:47 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 6d65640b1fcbdf26ea76cb720de0ac138cae9bed
Source-Link: googleapis/googleapis@6d65640
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/BaseBigQueryReadClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/BaseBigQueryReadSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/package-info.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/stub/BigQueryReadStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/stub/BigQueryReadStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/stub/GrpcBigQueryReadCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/stub/GrpcBigQueryReadStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/package-info.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/BigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/BigQueryWriteStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/GrpcBigQueryWriteCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/BaseBigQueryStorageClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/BaseBigQueryStorageSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/package-info.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/stub/BigQueryStorageStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/stub/BigQueryStorageStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/stub/GrpcBigQueryStorageCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta1/stub/GrpcBigQueryStorageStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BaseBigQueryReadClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BaseBigQueryReadSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BigQueryWriteClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BigQueryWriteSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/package-info.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/BigQueryReadStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/BigQueryReadStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/BigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/BigQueryWriteStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/GrpcBigQueryReadCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/GrpcBigQueryReadStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/GrpcBigQueryWriteCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/GrpcBigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/BaseBigQueryReadClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/MockBigQueryRead.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/MockBigQueryReadImpl.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWrite.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWriteImpl.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/BaseBigQueryStorageClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/MockBigQueryStorage.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/MockBigQueryStorageImpl.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/BaseBigQueryReadClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/BigQueryWriteClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/MockBigQueryRead.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/MockBigQueryReadImpl.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/MockBigQueryWrite.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/MockBigQueryWriteImpl.java
  • proto-google-cloud-bigquerystorage-v1/src/main/java/com/google/cloud/bigquery/storage/v1/ProjectName.java
  • proto-google-cloud-bigquerystorage-v1/src/main/java/com/google/cloud/bigquery/storage/v1/ReadSessionName.java
  • proto-google-cloud-bigquerystorage-v1/src/main/java/com/google/cloud/bigquery/storage/v1/ReadStreamName.java
  • proto-google-cloud-bigquerystorage-v1/src/main/java/com/google/cloud/bigquery/storage/v1/TableName.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/TableName.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java
  • proto-google-cloud-bigquerystorage-v1beta1/src/main/java/com/google/cloud/bigquery/storage/v1beta1/ProjectName.java
  • proto-google-cloud-bigquerystorage-v1beta1/src/main/java/com/google/cloud/bigquery/storage/v1beta1/ReadSessionName.java
  • proto-google-cloud-bigquerystorage-v1beta1/src/main/java/com/google/cloud/bigquery/storage/v1beta1/StreamName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequestOrBuilder.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponse.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/ProjectName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/ReadSessionName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/ReadStreamName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StorageProto.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamProto.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/TableName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/WriteStream.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/WriteStreamName.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/WriteStreamOrBuilder.java
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/proto/google/cloud/bigquery/storage/v1beta2/storage.proto
  • proto-google-cloud-bigquerystorage-v1beta2/src/main/proto/google/cloud/bigquery/storage/v1beta2/stream.proto

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Dec 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@stephaniewang526 stephaniewang526 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 15, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2020
@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Dec 15, 2020

cc @yirutang this PR involves breaking changes. Therefore, we need to add a clirr-ignored file to v1beta2 to get this through.

[INFO] Comparing to version: 0.107.0
[ERROR] 6011: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest: Field IGNORE_UNKNOWN_FIELDS_FIELD_NUMBER has been removed, but it was previously a constant
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest: Method 'public boolean getIgnoreUnknownFields()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder clearIgnoreUnknownFields()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder: Method 'public boolean getIgnoreUnknownFields()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder setIgnoreUnknownFields(boolean)' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequestOrBuilder: Method 'public boolean getIgnoreUnknownFields()' has been removed
[ERROR] 6011: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse: Field OFFSET_FIELD_NUMBER has been removed, but it was previously a constant
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse: Method 'public long getOffset()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder clearOffset()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder: Method 'public long getOffset()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder setOffset(long)' has been removed
[ERROR] 6001: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$ResponseCase: Removed field OFFSET
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponseOrBuilder: Method 'public long getOffset()' has been removed
[ERROR] 6011: com.google.cloud.bigquery.storage.v1beta2.WriteStream: Field EXTERNAL_ID_FIELD_NUMBER has been removed, but it was previously a constant
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream: Method 'public java.lang.String getExternalId()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream: Method 'public com.google.protobuf.ByteString getExternalIdBytes()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder clearExternalId()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder: Method 'public java.lang.String getExternalId()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder: Method 'public com.google.protobuf.ByteString getExternalIdBytes()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalId(java.lang.String)' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder: Method 'public com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalIdBytes(com.google.protobuf.ByteString)' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStreamOrBuilder: Method 'public java.lang.String getExternalId()' has been removed
[ERROR] 7002: com.google.cloud.bigquery.storage.v1beta2.WriteStreamOrBuilder: Method 'public com.google.protobuf.ByteString getExternalIdBytes()' has been removed

@stephaniewang526
Copy link
Contributor

@yirutang : made clirr-ignored changes and some more code changes: 5446659 to get this through. PTAL.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #728 (f1fe602) into master (c32a86a) will increase coverage by 0.50%.
The diff coverage is 72.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #728      +/-   ##
============================================
+ Coverage     80.25%   80.76%   +0.50%     
- Complexity      957      985      +28     
============================================
  Files            73       73              
  Lines          5319     5271      -48     
  Branches        401      402       +1     
============================================
- Hits           4269     4257      -12     
+ Misses          880      846      -34     
+ Partials        170      168       -2     
Impacted Files Coverage Δ Complexity Δ
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 60.97% <ø> (+17.07%) 12.00 <0.00> (+2.00)
...oud/bigquery/storage/v1/stub/BigQueryReadStub.java 25.00% <ø> (ø) 1.00 <0.00> (ø)
...query/storage/v1alpha2/stub/BigQueryWriteStub.java 14.28% <ø> (ø) 1.00 <0.00> (ø)
...uery/storage/v1beta1/stub/BigQueryStorageStub.java 16.66% <ø> (ø) 1.00 <0.00> (ø)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 60.97% <ø> (+17.07%) 12.00 <0.00> (+2.00)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 75.38% <ø> (+15.38%) 33.00 <0.00> (+6.00)
...igquery/storage/v1beta2/stub/BigQueryReadStub.java 25.00% <ø> (ø) 1.00 <0.00> (ø)
...gquery/storage/v1beta2/stub/BigQueryWriteStub.java 14.28% <ø> (ø) 1.00 <0.00> (ø)
...torage/v1beta2/stub/BigQueryWriteStubSettings.java 84.76% <46.15%> (-3.95%) 15.00 <0.00> (ø)
...storage/v1beta2/stub/BigQueryReadStubSettings.java 84.25% <47.61%> (-4.71%) 12.00 <0.00> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32a86a...f1fe602. Read the comment docs.

@stephaniewang526 stephaniewang526 changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. feat: updates to Write API v1beta2 public interface, migrate to Java microgenerator Dec 17, 2020
@stephaniewang526 stephaniewang526 merged commit 2fc5968 into master Dec 17, 2020
@stephaniewang526 stephaniewang526 deleted the autosynth-googleapis branch December 17, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants