KEMBAR78
Remove torch.export.export_for_inference by gmagogsfm · Pull Request #1877 · pytorch/ao · GitHub
Skip to content

Conversation

@gmagogsfm
Copy link
Contributor

@gmagogsfm gmagogsfm commented Mar 12, 2025

Summary: Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions()

Differential Revision: D71069057

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1877

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 9f59f1f with merge base ddb7f83 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

gmagogsfm added a commit to gmagogsfm/ao that referenced this pull request Mar 13, 2025
Summary:
X-link: pytorch/pytorch#149078


Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

gmagogsfm added a commit to gmagogsfm/pytorch-1 that referenced this pull request Mar 17, 2025
Summary:

X-link: pytorch/ao#1877

Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Test Plan: unit tests

Reviewed By: vkuzo

Differential Revision: D71069057
gmagogsfm added a commit to gmagogsfm/ao that referenced this pull request Mar 17, 2025
Summary:
X-link: pytorch/pytorch#149078


Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Reviewed By: vkuzo

Differential Revision: D71069057
gmagogsfm added a commit to gmagogsfm/ao that referenced this pull request Mar 17, 2025
Summary:
X-link: pytorch/pytorch#149078


Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

gmagogsfm added a commit to gmagogsfm/ao that referenced this pull request Mar 17, 2025
Summary:
X-link: pytorch/pytorch#149078

Pull Request resolved: pytorch#1877

Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

@gmagogsfm gmagogsfm added the topic: for developers Use this tag if this PR is mainly developer facing label Mar 18, 2025
gmagogsfm added a commit to gmagogsfm/ao that referenced this pull request Mar 18, 2025
Summary:
X-link: pytorch/pytorch#149078


Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

gmagogsfm added a commit to gmagogsfm/pytorch-1 that referenced this pull request Mar 18, 2025
Summary:

X-link: pytorch/ao#1877

Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False.

Test Plan: unit tests

Reviewed By: vkuzo

Differential Revision: D71069057
@gmagogsfm gmagogsfm changed the title Set default mode of export_for_inference to non-strict Remove torch.export.export_for_inference Mar 18, 2025
Summary:
X-link: pytorch/pytorch#149078


Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions()

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71069057

pytorch-bot bot pushed a commit to pytorch/pytorch that referenced this pull request Mar 19, 2025
Summary:

X-link: pytorch/ao#1877

Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions()

Test Plan: unit tests

Reviewed By: vkuzo

Differential Revision: D71069057
@facebook-github-bot facebook-github-bot merged commit cf82161 into pytorch:main Mar 19, 2025
17 of 20 checks passed
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Differential Revision: D71069057

Pull Request resolved: #1877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: for developers Use this tag if this PR is mainly developer facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants