Remove torch.export.export_for_inference #149078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmagogsfm
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149078
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit aec2922 with merge base 518563d ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
gmagogsfm
force-pushed
the
export-D71069057
branch
from
38b579b to
0aff281
Compare
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Mar 13, 2025
Summary: X-link: pytorch/ao#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 13, 2025
Summary: X-link: pytorch/pytorch#149078 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
force-pushed
the
export-D71069057
branch
from
0aff281 to
f810cb3
Compare
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Mar 17, 2025
Summary: X-link: pytorch/ao#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 17, 2025
Summary: X-link: pytorch/pytorch#149078 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 17, 2025
Summary: X-link: pytorch/pytorch#149078 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 17, 2025
Summary: X-link: pytorch/pytorch#149078 Pull Request resolved: pytorch#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Mar 17, 2025
Summary: X-link: pytorch/ao#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
force-pushed
the
export-D71069057
branch
from
f810cb3 to
48e25f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Mar 17, 2025
Summary: Pull Request resolved: pytorch#149078 X-link: pytorch/ao#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
force-pushed
the
export-D71069057
branch
from
48e25f5 to
41c60f0
Compare
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 18, 2025
Summary: X-link: pytorch/pytorch#149078 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
force-pushed
the
export-D71069057
branch
from
41c60f0 to
343f1bc
Compare
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Mar 18, 2025
Summary: X-link: pytorch/ao#1877 Add explicit strict=True argument to export_for_inference callsites and flip default value of strict argument to False. Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
gmagogsfm
changed the title
gmagogsfm
added a commit
to gmagogsfm/ao
that referenced
this pull request
Mar 19, 2025
Summary: X-link: pytorch/pytorch#149078 Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions() Reviewed By: vkuzo Differential Revision: D71069057
Summary: X-link: pytorch/ao#1877 Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions() Test Plan: unit tests Reviewed By: vkuzo Differential Revision: D71069057
gmagogsfm
force-pushed
the
export-D71069057
branch
from
343f1bc to
aec2922
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71069057 |
tugsbayasgalan
approved these changes
Mar 19, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Summary: Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions() Test Plan: unit tests Differential Revision: D71069057 Pull Request resolved: pytorch#149078 Approved by: https://github.com/tugsbayasgalan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove torch.export.export_for_inference, it is redundant and can always be replaced with torch.export.export_for_training() + run_decompositions()
Test Plan: unit tests
Differential Revision: D71069057
cc @ezyang @gchanan