Fix error in div lowering with integers #102809
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102809
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 9286860 with merge base 08c7dcd ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @register_lowering([prims.div], broadcast=True) | ||
| def div_prim(a, b): | ||
| is_integral = is_boolean_type(a) or is_integer_type(a) | ||
| is_integral = all(is_boolean_type(x) or is_integer_type(x) for x in [a, b]) |
There was a problem hiding this comment.
Why does type promotion not promote scalar values?
There was a problem hiding this comment.
yeah I thought it would, but it doesn't seem to in this case :/ Didn't look more into it since this fix is fairly reasonable.
There was a problem hiding this comment.
I guess fmod will need the same fix then, since it uses the same is_integral test.
There was a problem hiding this comment.
I can't seem to hit the same codepath with fmod, perhaps because it doesn't take in a scalar as an input.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel Fixes #101016 [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel Fixes #101016 [ghstack-poisoned]
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov Fixes #101016 [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov Fixes #101016 [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "failures unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot drci (Please ignore this comment, I'm testing Dr.CI) |
ghstack-source-id: 19f0c4f Pull Request resolved: pytorch/pytorch#102809
ghstack-source-id: 4da6bfd Pull Request resolved: pytorch/pytorch#102809
5 participants
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @ngimel
Fixes #101016