KEMBAR78
Add option to flop counter formula registration to get raw values by Chillee · Pull Request #110591 · pytorch/pytorch · GitHub
Skip to content

Add option to flop counter formula registration to get raw values #110591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add option to flop counter formula registration to get raw values #110591

wants to merge 1 commit into from

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Oct 5, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110591

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4182d24 with merge base 08c7dcd (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Chillee added a commit that referenced this pull request Oct 5, 2023
@Chillee
Add option to flop counter formula registration to get raw values
ec7a552 
ghstack-source-id: 2cc6eb4
Pull Request resolved: #110591
@github-actions github-actions bot requested a review from ezyang October 5, 2023 08:29
@Chillee Chillee mentioned this pull request Oct 5, 2023
Closed
@Chillee
Copy link
Collaborator Author

Chillee commented Oct 5, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@Chillee Chillee added the release notes: visualization release notes category label Oct 5, 2023
@Chillee
Copy link
Collaborator Author

Chillee commented Oct 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Chillee Chillee mentioned this pull request Oct 6, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 6, 2023
@Chillee @pytorchmergebot
Added strict=True to zip in aot_autograd (#110668)
6d23193 
Pull Request resolved: #110668
Approved by: https://github.com/ezyang
ghstack dependencies: #110501, #110504, #110591
This was referenced Oct 6, 2023
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 6, 2023
@Chillee @pytorchmergebot
Fix #110680 (requires_grad typo in decomp) (#110687)
ceb773b 
Fixes #110680
Pull Request resolved: #110687
Approved by: https://github.com/voznesenskym, https://github.com/lezcano
ghstack dependencies: #110501, #110504, #110591, #110668
This was referenced Oct 6, 2023
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 6, 2023
@Chillee @pytorchmergebot
Fix error in div lowering with integers (#102809)
6b1007b 
Fixes #101016
Pull Request resolved: #102809
Approved by: https://github.com/ngimel
ghstack dependencies: #110501, #110504, #110591, #110668, #110687
@Chillee Chillee mentioned this pull request Oct 6, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/chillee/223/head branch October 9, 2023 14:29
Chillee added a commit that referenced this pull request Oct 24, 2023
@Chillee
Fix #110680 (requires_grad typo in decomp) (#110687)
709ef06 
Fixes #110680
Pull Request resolved: #110687
Approved by: https://github.com/voznesenskym, https://github.com/lezcano
ghstack dependencies: #110501, #110504, #110591, #110668
malfet pushed a commit that referenced this pull request Oct 26, 2023
@Chillee
Fix #110680 (requires_grad typo in decomp) (#110687) (#111955)
cd58593 
Fixes #110680
Pull Request resolved: #110687
Approved by: https://github.com/voznesenskym, https://github.com/lezcano
ghstack dependencies: #110501, #110504, #110591, #110668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu awgu approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: visualization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chillee @pytorchmergebot @awgu