[RFC][FSDP] Don't move ignored params / buffers to device #108033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
fduwjj,
fegin,
kwen2501,
mrshenli,
wanchaol,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108033
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ✅ No FailuresAs of commit 9a5eae4 with merge base a20fac8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
rohan-varma
added a commit
that referenced
this pull request
Aug 28, 2023
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) ghstack-source-id: 198857863 Pull Request resolved: #108033
awgu
reviewed
Aug 31, 2023
| import torch.distributed.fsdp._traversal_utils as traversal_utils | ||
| import torch.distributed.fsdp.fully_sharded_data_parallel as fsdp_file | ||
| import torch.nn as nn | ||
| from torch import Tensor |
There was a problem hiding this comment.
nit: If we do this, I feel like we should replace all torch.Tensor in the file with Tensor, or else it gets fragmented.
Maybe just use torch.Tensor on L857?
| for submodule in curr_module.children(): | ||
| if not isinstance(submodule, fsdp_file.FullyShardedDataParallel): | ||
| queue.append(submodule) | ||
| # NOTE: This includes moving ignored modules' parameters. If we |
|
I am on board with the change. |
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Sep 1, 2023
Pull Request resolved: #108033 Since these are ignored by FSDP, don't move them. ghstack-source-id: 199417931 @exported-using-ghexport Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/)
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) [ghstack-poisoned]
awgu
approved these changes
Sep 1, 2023
|
Please check lint before landing. Thanks! |
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) [ghstack-poisoned]
Since these are ignored by FSDP, don't move them. Differential Revision: [D48727044](https://our.internmc.facebook.com/intern/diff/D48727044/) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 5, 2023
…NTRANT (#108435) We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/) Pull Request resolved: #108435 Approved by: https://github.com/awgu ghstack dependencies: #108032, #108033
ppwwyyxx
reviewed
May 8, 2024
| ignored_buffers: Set[torch.Tensor], | ||
| device_from_device_id: Optional[torch.device], | ||
| ) -> None: | ||
| """ |
There was a problem hiding this comment.
the docstring below should be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Since these are ignored by FSDP, don't move them.
Differential Revision: D48727044