[RFC] Somewhat BC breaking: make checkpoint_wrapper default to NO_REENTRANT #108435
Conversation
…NTRANT We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
wanchaol,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108435
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ✅ No FailuresAs of commit 81a493e with merge base a20fac8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…NTRANT We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/) ghstack-source-id: 199491501 Pull Request resolved: #108435
…t to NO_REENTRANT" We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/) [ghstack-poisoned]
…t to NO_REENTRANT" We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/) [ghstack-poisoned]
…NTRANT Pull Request resolved: #108435 We should use no_reentrant. There are a lot of users of this API, but it is in a prototype state so should be fine to change. ghstack-source-id: 199693434 @exported-using-ghexport Differential Revision: [D48898148](https://our.internmc.facebook.com/intern/diff/D48898148/)
|
@pytorchbot merge -f "CI done, bottom diff is flaky" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Is this going to be included in 2.1? |
|
@carmocca I believe branch cut was Fri so it did not make it. |
4 participants
Stack from ghstack (oldest at bottom):
We should use no_reentrant. There are a lot of users of this API, but
it is in a prototype state so should be fine to change.
Differential Revision: D48898148