KEMBAR78
NT support for narrow() on dim=0 by jbschlosser · Pull Request #108362 · pytorch/pytorch · GitHub
Skip to content

NT support for narrow() on dim=0 #108362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

NT support for narrow() on dim=0 #108362

wants to merge 2 commits into from

Conversation

@jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented Aug 31, 2023 •
edited
Loading

@jbschlosser jbschlosser mentioned this pull request Aug 31, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108362

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aa5b503 with merge base dcc674d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jbschlosser added a commit that referenced this pull request Aug 31, 2023
@jbschlosser
NT support for narrow() on dim=0
178cbf8 
ghstack-source-id: c0b1354
Pull Request resolved: #108362
@jbschlosser jbschlosser requested a review from cpuhrsch August 31, 2023 19:37
cpuhrsch
cpuhrsch reviewed Aug 31, 2023
View reviewed changes
cpuhrsch
cpuhrsch reviewed Aug 31, 2023
View reviewed changes
@jbschlosser jbschlosser mentioned this pull request Aug 31, 2023
Closed
@jbschlosser jbschlosser added topic: improvements topic category release notes: nested tensor Changes that have a direct impact on nested tensors labels Sep 1, 2023
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 1, 2023

This PR needs to be approved by an authorized maintainer before merge.

@jbschlosser jbschlosser mentioned this pull request Sep 1, 2023
Closed
@jbschlosser
Update on "NT support for narrow() on dim=0"
aa5b503 
Satisfies request here: #105913 (comment)

[ghstack-poisoned]
@jbschlosser jbschlosser requested a review from cpuhrsch September 1, 2023 17:12
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 1, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral), trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Sep 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 3, 2023
@jbschlosser @pytorchmergebot
NT support for cat with dim > 0 when representable as jagged (#108428)
e5548f8 
Used in SAM
Pull Request resolved: #108428
Approved by: https://github.com/cpuhrsch
ghstack dependencies: #108361, #108370, #108362
@facebook-github-bot facebook-github-bot deleted the gh/jbschlosser/92/head branch September 6, 2023 14:22
@jbschlosser jbschlosser mentioned this pull request Sep 7, 2023
Open
@davidbuterez
Copy link

davidbuterez commented Sep 17, 2024 •
edited
Loading

@jbschlosser Thanks, this seems very useful! Unfortunately I ran into this error when using torch.narrow and training with nested tensors: RuntimeError: derivative for aten::narrow is not implemented (PyTorch version 2.5.0.dev20240909). Is there any chance this could be looked at? I am using it in the first dimension, as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbschlosser @pytorchmergebot @cpuhrsch @davidbuterez