Deprecate torch.cross default behaviour #108760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long overdue this one. We may be able to change it in a few years :hopeful:. **BC-breaking note** This PR deprecates `torch.cross`'s default dim in favor of `torch.linalg.cross`. A upgrade guide is added to the documentation for `torch.cross`. Note this PR DOES NOT remove `torch.cross`. Fixes #108664 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108760
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ad88b70 with merge base 06b1737 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lezcano
added a commit
that referenced
this pull request
Sep 7, 2023
Long overdue this one. We may be able to change it in a few years :hopeful:. **BC-breaking note** This PR deprecates `torch.cross`'s default dim in favor of `torch.linalg.cross`. A upgrade guide is added to the documentation for `torch.cross`. Note this PR DOES NOT remove `torch.cross`. Fixes #108664 ghstack-source-id: fb21a77 Pull Request resolved: #108760
lezcano
added
module: linear algebra
|
That Softmax deprecation may be more painful, and it'll need to be done by someone at meta. Feel free to poke them in that other issue. |
|
Yeah, for softmax default dim was deprecated for a few years no, but still not removed :) which makes it have a functional wrapper and nasty stacklevel arg |
albanD
approved these changes
Sep 14, 2023
aten/src/ATen/native/Cross.cpp
Outdated
| if (!dimension) { | ||
| TORCH_WARN_ONCE( | ||
| "Using torch.cross without specifying the dim arg is deprecated.\n", | ||
| "Please either pass the dim explicitly or simply use linalg.cross.\n", |
There was a problem hiding this comment.
nit:
Suggested change
| "Please either pass the dim explicitly or simply use linalg.cross.\n", | |
| "Please either pass the dim explicitly or simply use torch.linalg.cross.\n", |
Long overdue this one. We may be able to change it in a few years :hopeful:. **BC-breaking note** This PR deprecates `torch.cross`'s default dim in favor of `torch.linalg.cross`. A upgrade guide is added to the documentation for `torch.cross`. Note this PR DOES NOT remove `torch.cross`. Fixes #108664 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Sep 14, 2023
Long overdue this one. We may be able to change it in a few years :hopeful:. **BC-breaking note** This PR deprecates `torch.cross`'s default dim in favor of `torch.linalg.cross`. A upgrade guide is added to the documentation for `torch.cross`. Note this PR DOES NOT remove `torch.cross`. Fixes #108664 ghstack-source-id: 3e7bae9 Pull Request resolved: #108760
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Long overdue this one. We may be able to change it in a few years :hopeful:.
BC-breaking note
This PR deprecates
torch.cross's default dim in favor oftorch.linalg.cross.A upgrade guide is added to the documentation for
torch.cross.Note this PR DOES NOT remove
torch.cross.Fixes #108664
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano