[core IR] Add glu as a core decomposition #110043

SS-JIA · 2023-09-25T22:15:55Z

Stack from ghstack (oldest at bottom):

Context

Add the decomposition for aten.glu as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

[ghstack-poisoned]

pytorch-bot · 2023-09-25T22:15:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110043

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 516d8c5 with merge base 129f535 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 597ac7f Pull Request resolved: #110043

## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]

ghstack-source-id: 1d744ae Pull Request resolved: #110043

SS-JIA · 2023-09-26T04:58:11Z

@pytorchbot merge -g

pytorch-bot · 2023-09-26T04:58:13Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

SS-JIA · 2023-09-26T04:58:25Z

@pytorchbot merge

pytorchmergebot · 2023-09-26T05:00:51Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-09-26T07:33:02Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu)

Details for Dev Infra team

Raised by workflow job

SS-JIA · 2023-09-26T14:11:57Z

@pytorchbot merge

pytorchmergebot · 2023-09-26T14:15:47Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-09-26T16:17:37Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 60d15a81fae7a6088c87212c0225955a738d7610 returned non-zero exit code 1

Auto-merging test/expect/HasDecompTest.test_aten_core_operators.expect
Auto-merging torch/_decomp/__init__.py
Auto-merging torch/_inductor/decomposition.py
CONFLICT (content): Merge conflict in torch/_inductor/decomposition.py
error: could not apply 60d15a81fae... [core IR] Add glu as a core decomposition
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]

ghstack-source-id: f8d6325 Pull Request resolved: #110043

SS-JIA · 2023-09-26T19:09:07Z

@pytorchbot merge

pytorchmergebot · 2023-09-26T19:11:05Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]

ghstack-source-id: 03dbc68 Pull Request resolved: #110043

pytorchmergebot · 2023-09-26T19:56:40Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

lezcano

At some point we should audit whether we can remove some of those lowerings form Inductor, but this is already a first step :)

SS-JIA · 2023-09-26T20:53:02Z

PYTORCH_TEST_WITH_DYNAMO=1 python test_ops.py -k test_out_warning__refs_clamp_cpu

The failing test is reproducible on the base commit. Likely not related to these changes.

SS-JIA · 2023-09-26T21:45:44Z

@pytorchbot merge -i

pytorchmergebot · 2023-09-26T21:47:35Z

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 2, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[core IR] Add glu as a core decomposition

fb64a99

[ghstack-poisoned]

SS-JIA added a commit that referenced this pull request Sep 25, 2023

[core IR] Add glu as a core decomposition

df92fc4

ghstack-source-id: 597ac7f Pull Request resolved: #110043

github-actions bot added module: inductor ciflow/inductor labels Sep 25, 2023

SS-JIA requested review from SherlockNoMad, kimishpatel and peterbell10 September 25, 2023 22:16

SS-JIA added the module: export label Sep 25, 2023

SS-JIA mentioned this pull request Sep 25, 2023

[Decomposition] glu #109618

Closed

peterbell10 approved these changes Sep 25, 2023

View reviewed changes

SS-JIA added the release notes: export label Sep 26, 2023

SS-JIA added a commit that referenced this pull request Sep 26, 2023

[core IR] Add glu as a core decomposition

60d15a8

ghstack-source-id: 1d744ae Pull Request resolved: #110043

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2023

pytorchmergebot added the merging label Sep 26, 2023

pytorchmergebot removed the merging label Sep 26, 2023

pytorchmergebot added the merging label Sep 26, 2023

pytorchmergebot removed the merging label Sep 26, 2023

SS-JIA added a commit that referenced this pull request Sep 26, 2023

[core IR] Add glu as a core decomposition

04872d8

ghstack-source-id: f8d6325 Pull Request resolved: #110043

pytorchmergebot added the merging label Sep 26, 2023

SS-JIA added a commit that referenced this pull request Sep 26, 2023

[core IR] Add glu as a core decomposition

ad3b241

ghstack-source-id: 03dbc68 Pull Request resolved: #110043

pytorchmergebot removed the merging label Sep 26, 2023

SS-JIA mentioned this pull request Sep 26, 2023

[core IR] Add lift_fresh, split.Tensor, and unbind decompositions to core ATen decomp table #110102

Closed

lezcano approved these changes Sep 26, 2023

View reviewed changes

pytorchmergebot added the merging label Sep 26, 2023

pytorchmergebot added Merged and removed merging labels Sep 27, 2023

pytorchmergebot closed this in 9928c10 Sep 27, 2023

facebook-github-bot deleted the gh/SS-JIA/171/head branch September 30, 2023 14:22

[core IR] Add glu as a core decomposition #110043

[core IR] Add glu as a core decomposition #110043

Uh oh!

Conversation

SS-JIA commented Sep 25, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Uh oh!

pytorch-bot bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110043

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

pytorch-bot bot commented Sep 26, 2023

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge failed

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge failed

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge failed

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

SS-JIA commented Sep 26, 2023

Uh oh!

pytorchmergebot commented Sep 26, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SS-JIA commented Sep 25, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 25, 2023 •

edited

Loading