[core IR] Add a core decomposition for floor_divide #110046
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110046
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 75d4547 with merge base 52e1478 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
## Context Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table. [ghstack-poisoned]
|
I don't quite remember what was the issue here really. I think that back then, our lowering for If this was indeed the reason (let's see if Peter remembers) then I guess we can move it to core, yep. |
## Context Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table. This replaces the decomposition of `floor_divide` that was used by Inductor. I noticed there was a note on that decomposition ``` # TorchInductor-only decomposition. It should not be taken to core. # See pytorch/torchdynamo#1120 ``` but couldn't discern the reason why this is the case. cc: lezcano cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. Pull Request resolved: #110043 Approved by: https://github.com/peterbell10, https://github.com/lezcano ghstack dependencies: #110046
ghstack-source-id: 37b9e14 Pull Request resolved: pytorch/pytorch#110046
4 participants
Stack from ghstack (oldest at bottom):
Context
Introduce a core decomposition for
aten.floor_divideinto otheratenops, and add it to the core ATen decomposition table.This replaces the decomposition of
floor_dividethat was used by Inductor. I noticed there was a note on that decompositionbut couldn't discern the reason why this is the case. cc: @lezcano
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov