[PyTorch] -DNDEBUG in inductor codecache builds #110876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110876
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1a07779 with merge base 2edc75a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Oct 9, 2023
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) ghstack-source-id: 203390726 Pull Request resolved: #110876
swolchok
requested review from
bertmaher,
chenyang78,
jansel,
mikekgfb and
msaroufim
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
jansel
approved these changes
Oct 10, 2023
desertfire
approved these changes
Oct 10, 2023
…uilds" Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this! Differential Revision: [D49972742](https://our.internmc.facebook.com/intern/diff/D49972742/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2023
This seems to reduce benchmark time by 15-20%. Supersedes D49835545. Differential Revision: [D49974460](https://our.internmc.facebook.com/intern/diff/D49974460/) Pull Request resolved: #110877 Approved by: https://github.com/chenyang78, https://github.com/jansel, https://github.com/desertfire ghstack dependencies: #110876
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2023
I need this to do a cheap and easy output copy in D50023678. Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/) Pull Request resolved: #110909 Approved by: https://github.com/jansel, https://github.com/chenyang78, https://github.com/desertfire ghstack dependencies: #110876, #110877
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 13, 2023
…ave static shape (#110892) If a Tensor can be reused and has static shape, we can just cache it across iterations. This is meant as a quickly shippable overhead reduction for CPU overhead-bound use cases that we can ship without relying on memory planning. Differential Revision: [D50023678](https://our.internmc.facebook.com/intern/diff/D50023678/) Pull Request resolved: #110892 Approved by: https://github.com/bertmaher ghstack dependencies: #110876, #110877, #110909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Things like TORCH_INTERNAL_ASSERT_DEBUG_ONLY care about this!
Differential Revision: D49972742
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler