KEMBAR78
[PyTorch] AOTI: Add aoti_torch_assign_tensors to ABI by swolchok · Pull Request #110909 · pytorch/pytorch · GitHub
Skip to content

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Oct 9, 2023

I need this to do a cheap and easy output copy in D50023678.

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110909

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ab52f35 with merge base 2edc75a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@swolchok swolchok added the topic: not user facing topic category label Oct 10, 2023
…ors to ABI"

I need this to do a cheap and easy output copy in D50023678.

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)

[ghstack-poisoned]
@swolchok swolchok force-pushed the gh/swolchok/589/head branch from cdee29d to 544a27f Compare October 10, 2023 19:50
@swolchok
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

I need this to do a cheap and easy output copy in D50023678.

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)

[ghstack-poisoned]
@swolchok swolchok force-pushed the gh/swolchok/589/head branch from 544a27f to 76f8e57 Compare October 12, 2023 17:49
swolchok added a commit that referenced this pull request Oct 12, 2023
Pull Request resolved: #110909

I need this to do a cheap and easy output copy in D50023678.
ghstack-source-id: 203862255
@exported-using-ghexport

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)
I need this to do a cheap and easy output copy in D50023678.

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Oct 12, 2023
Pull Request resolved: #110909

I need this to do a cheap and easy output copy in D50023678.
ghstack-source-id: 203923767
@exported-using-ghexport

Differential Revision: [D50105080](https://our.internmc.facebook.com/intern/diff/D50105080/)
pytorchmergebot pushed a commit that referenced this pull request Oct 13, 2023
…ave static shape (#110892)

If a Tensor can be reused and has static shape, we can just cache it across iterations.

This is meant as a quickly shippable overhead reduction for CPU overhead-bound use cases that we can ship without relying on memory planning.

Differential Revision: [D50023678](https://our.internmc.facebook.com/intern/diff/D50023678/)

Pull Request resolved: #110892
Approved by: https://github.com/bertmaher
ghstack dependencies: #110876, #110877, #110909
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/589/head branch October 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants