KEMBAR78
Do not error when printing view created in no-grad modified in-place in no-grad by soulitzer · Pull Request #113716 · pytorch/pytorch · GitHub
Skip to content

Do not error when printing view created in no-grad modified in-place in no-grad #113716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Do not error when printing view created in no-grad modified in-place in no-grad #113716

wants to merge 6 commits into from

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Nov 14, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113716

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit af572b7 with merge base f5ce4d8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer requested a review from albanD November 15, 2023 00:00
@soulitzer
Update on "Do not error when printing view created in no-grad modifie…
1ebdf48 
…d in-place in no-grad"


Fixes #99968


[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Nov 15, 2023
@soulitzer
Do not error when printing view created in no-grad modified in-place …
f1d50e7 
…in no-grad

ghstack-source-id: 2155d39
Pull Request resolved: #113716
@soulitzer
Update on "Do not error when printing view created in no-grad modifie…
cafc31b 
…d in-place in no-grad"


Fixes #99968


[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Nov 15, 2023
@soulitzer
Do not error when printing view created in no-grad modified in-place …
342709d 
…in no-grad

ghstack-source-id: 0dc21dc
Pull Request resolved: #113716
albanD
albanD reviewed Nov 15, 2023
View reviewed changes
@soulitzer
Update on "Do not error when printing view created in no-grad modifie…
7c177cf 
…d in-place in no-grad"


Fixes #99968


[ghstack-poisoned]
@soulitzer
Update on "Do not error when printing view created in no-grad modifie…
202fd81 
…d in-place in no-grad"


Fixes #99968


[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Nov 15, 2023
@soulitzer
Do not error when printing view created in no-grad modified in-place …
71f5e52 
…in no-grad

ghstack-source-id: 2040f21
Pull Request resolved: #113716
@soulitzer soulitzer requested a review from albanD November 15, 2023 17:16
@soulitzer soulitzer mentioned this pull request Nov 16, 2023
Closed
albanD
albanD approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@soulitzer
Update on "Do not error when printing view created in no-grad modifie…
af572b7 
…d in-place in no-grad"


Fixes #99968


[ghstack-poisoned]
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 16, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@soulitzer soulitzer added release notes: autograd release notes category topic: bug fixes topic category labels Nov 16, 2023
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/soulitzer/252/head branch November 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: autograd release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soulitzer @pytorchmergebot @albanD