[ignore] Track symints on bases of NT views during guard creation #113849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113849
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5308564 with merge base f5ce4d8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
commented
Nov 16, 2023
| # However, NT and any other subclass that does not support as_strided | ||
| # must rely instead on view_func to do this replaying. In this case, | ||
| # the base must be metafied with dynamic DimDynamic and thus have | ||
| # symints allocated, which then need to be tracked. |
There was a problem hiding this comment.
Alternatively, it might be better to just symintify AFTER replaying the view_func. That would avoid having to track the symints on the base here.
soulitzer
changed the title
…reation" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
|
This doesn't seem feasible because it is difficult to map dynamic dims of inputs back to bases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng