Update matmul requires_grad checks #117067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
soulitzer
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117067
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b653a8b with merge base e5f2ac1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lezcano
approved these changes
Jan 10, 2024
albanD
approved these changes
Jan 10, 2024
Fixes #116099 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Looks like this caused a perf regression, see pytorch/benchmark#2139 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
…rad tensor (#150270) Fixes #147846. Previously there is no error out under out variant of`tensordot` while `requires_grad=True`. This can cause potential issue when out tensor is part of a computation graph. Enforces the out variant of tensordot to run without setting `requries_grad=True`. Change same to #117067 Pull Request resolved: #150270 Approved by: https://github.com/soulitzer
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
…rad tensor (pytorch#150270) Fixes pytorch#147846. Previously there is no error out under out variant of`tensordot` while `requires_grad=True`. This can cause potential issue when out tensor is part of a computation graph. Enforces the out variant of tensordot to run without setting `requries_grad=True`. Change same to pytorch#117067 Pull Request resolved: pytorch#150270 Approved by: https://github.com/soulitzer
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…rad tensor (pytorch#150270) Fixes pytorch#147846. Previously there is no error out under out variant of`tensordot` while `requires_grad=True`. This can cause potential issue when out tensor is part of a computation graph. Enforces the out variant of tensordot to run without setting `requries_grad=True`. Change same to pytorch#117067 Pull Request resolved: pytorch#150270 Approved by: https://github.com/soulitzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #116099