Add error check for out variant of tensordot function with requries_grad tensor #150270
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150270
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 61f7165 with merge base 732f9d7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added
the
triaged
soulitzer
added
module: bc-breaking
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-libtorch / libtorch-cpu-shared-with-deps-release-build / build Details for Dev Infra teamRaised by workflow job |
|
Hi @soulitzer, thanks for the help, can you help trigger the CI again please? The test case failure is specific to CUDA tensor and should be fixed now. For the build issues, I am not sure why they are there. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 jobs have failed, first few of them are: linux-binary-libtorch / libtorch-cpu-shared-with-deps-release-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build Details for Dev Infra teamRaised by workflow job |
|
Hi @zou3519 ,@soulitzer the build failure seems unrelated to my change. Do we have a workaround to pass the Ci? Thanks in advance. |
|
@pytorchbot merge -i |
|
@cz2h Yes, it is possible to merge with the ignore option to ignore failures that are unrelated |
Merge startedYour change will be merged while ignoring the following 5 checks: pull / linux-jammy-py3.9-gcc11 / test (backwards_compat, 1, 1, ephemeral.linux.2xlarge), linux-binary-libtorch / libtorch-cpu-shared-with-deps-release-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_6-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_8-build / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Thank you, appreciate it :) |
…rad tensor (pytorch#150270) Fixes pytorch#147846. Previously there is no error out under out variant of`tensordot` while `requires_grad=True`. This can cause potential issue when out tensor is part of a computation graph. Enforces the out variant of tensordot to run without setting `requries_grad=True`. Change same to pytorch#117067 Pull Request resolved: pytorch#150270 Approved by: https://github.com/soulitzer
…rad tensor (pytorch#150270) Fixes pytorch#147846. Previously there is no error out under out variant of`tensordot` while `requires_grad=True`. This can cause potential issue when out tensor is part of a computation graph. Enforces the out variant of tensordot to run without setting `requries_grad=True`. Change same to pytorch#117067 Pull Request resolved: pytorch#150270 Approved by: https://github.com/soulitzer
5 participants
Fixes #147846. Previously there is no error out under out variant of
tensordotwhilerequires_grad=True. This can cause potential issue when out tensor is part of a computation graph.Enforces the out variant of tensordot to run without setting
requries_grad=True. Change same to #117067cc @ezyang @gchanan