Mark PyTorch module as no-gil valid and pythoncapi_compat.h #136899
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136899
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 99a6f53 with merge base dfe1d45 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) Details for Dev Infra teamRaised by workflow job |
|
Added back this old function we don't need because our c++ only build actually build with cpython 3.8 which we don't support and should never use. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build Details for Dev Infra teamRaised by workflow job |
…ason" This reverts commit 9db686e.
|
libtorch build should have been fixed in pytorch/builder#2000 so this should go through now ! |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…136899) PyList_GetItem are audited but not other APIs yet (they will be done in a follow up PR to keep this one small enough). Pull Request resolved: pytorch#136899 Approved by: https://github.com/colesbury, https://github.com/atalman
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@albanD your PR has been successfully reverted. |
…136899)" This reverts commit 4f93de8. Reverted #136899 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#136899 (comment)))
…136899) PyList_GetItem are audited but not other APIs yet (they will be done in a follow up PR to keep this one small enough). Pull Request resolved: pytorch#136899 Approved by: https://github.com/colesbury, https://github.com/atalman
Cover the PyDict APIs and confirms no update needed for PyModule one. The rest was already covered in #136899 Pull Request resolved: #137142 Approved by: https://github.com/eqy, https://github.com/Skylion007
Cover the PyDict APIs and confirms no update needed for PyModule one. The rest was already covered in pytorch#136899 Pull Request resolved: pytorch#137142 Approved by: https://github.com/eqy, https://github.com/Skylion007
5 participants
PyList_GetItem are audited but not other APIs yet (they will be done in a follow up PR to keep this one small enough).
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec