KEMBAR78
More nogil unsafe API fix by albanD · Pull Request #137142 · pytorch/pytorch · GitHub
Skip to content

More nogil unsafe API fix #137142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

More nogil unsafe API fix #137142

wants to merge 3 commits into from

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Oct 1, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137142

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 468670c with merge base c7b0d4b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD requested a review from colesbury October 1, 2024 22:46
eqy
eqy approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CUDA module changes

@albanD albanD added the topic: not user facing topic category label Oct 1, 2024
@Skylion007
Copy link
Collaborator

Rest of Python changes look good.

albanD added 2 commits October 4, 2024 13:26
@albanD
Mark PyTorch module as no-gil valid and pythoncapi_compat.h (pytorch#…
0cb3620 
…136899)

PyList_GetItem are audited but not other APIs yet (they will be done in a follow up PR to keep this one small enough).

Pull Request resolved: pytorch#136899
Approved by: https://github.com/colesbury, https://github.com/atalman
@albanD
More nogil unsafe API fix
9d10bcf
@albanD albanD requested a review from a team as a code owner October 4, 2024 17:49
@albanD
Copy link
Collaborator Author

albanD commented Oct 4, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@albanD
Copy link
Collaborator Author

albanD commented Oct 4, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

albanD added a commit to albanD/pytorch that referenced this pull request Oct 18, 2024
@albanD
More nogil unsafe API fix (pytorch#137142)
0c2b29e 
Cover the PyDict APIs and confirms no update needed for PyModule one.
The rest was already covered in pytorch#136899

Pull Request resolved: pytorch#137142
Approved by: https://github.com/eqy, https://github.com/Skylion007
@albanD albanD mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@eqy eqy eqy approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

@colesbury colesbury Awaiting requested review from colesbury

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albanD @Skylion007 @pytorchmergebot @eqy