KEMBAR78
[MPS] Fix Gamma for bfloat16 dtypes by malfet · Pull Request #136981 · pytorch/pytorch · GitHub
Skip to content

[MPS] Fix Gamma for bfloat16 dtypes #136981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Fix Gamma for bfloat16 dtypes #136981

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 30, 2024 •
edited
Loading

@malfet
[MPS] Fix Gamma for bfloat16 dtypes
b6ad8e6 
Before this change, test failed with unable to compile errors

[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner September 30, 2024 05:29
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136981

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit b6ad8e6 with merge base 156ca01 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 30, 2024
This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@malfet malfet added the topic: improvements topic category label Sep 30, 2024
@malfet malfet requested review from Skylion007 and albanD September 30, 2024 13:51
This was referenced Sep 30, 2024
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS] Extend fmin/fmax/copysign and nextafter to blfoat (#136982
3ed2969 
)

Just adds instantiation of the kernels and sometimes explicit cast.
Tested in #136987
Pull Request resolved: #136982
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS] Enable bucketization for bfloat16 (#136983)
33d3d6e 
By simply adding explicit instantiation
Tested in #136987

Pull Request resolved: #136983
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS] Enable torch.linalg.cross for bfloat16 (#136984)
538fcd7 
By adding explicit instantiation. Tested in #136987
Pull Request resolved: #136984
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982, #136983
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS] Enable Renorm for bfloat16 (#136985)
d8d3aea 
Pull Request resolved: #136985
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982, #136983, #136984
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS] Enable nan_to_num for bfloat16 (#136986)
ae3d5ed 
Pull Request resolved: #136986
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982, #136983, #136984, #136985
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
Testing: Unblock new_* testing on MPS (#137003)
c610aa8 
By changing `other_dtype` to `torch.half` rather than `double` in
`sample_inputs_new_fns` if MPS is available
Pull Request resolved: #137003
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982, #136983, #136984, #136985, #136986
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@malfet @pytorchmergebot
[MPS][BE] Use None as alias for all types (#137004)
4af03e5 
Test like `new_*` and `empty_*` fail the current implementation, see
Pull Request resolved: #137004
Approved by: https://github.com/Skylion007
ghstack dependencies: #136981, #136982, #136983, #136984, #136985, #136986, #137003
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Fix Gamma for bfloat16 dtypes (pytorch#136981)
20c7fc8 
Before this change, test failed with unable to compile errors, as `bfloat16` requires explicit cast.
Tested in pytorch#136987
Pull Request resolved: pytorch#136981
Approved by: https://github.com/Skylion007
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Extend fmin/fmax/copysign and nextafter to blfoat (pyto…
2045b75 
…rch#136982)

Just adds instantiation of the kernels and sometimes explicit cast.
Tested in pytorch#136987
Pull Request resolved: pytorch#136982
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Enable bucketization for bfloat16 (pytorch#136983)
9845028 
By simply adding explicit instantiation
Tested in pytorch#136987

Pull Request resolved: pytorch#136983
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Enable torch.linalg.cross for bfloat16 (pytorch#136984)
e7aed85 
By adding explicit instantiation. Tested in pytorch#136987
Pull Request resolved: pytorch#136984
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Enable Renorm for bfloat16 (pytorch#136985)
e528d34 
Pull Request resolved: pytorch#136985
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS] Enable nan_to_num for bfloat16 (pytorch#136986)
a00f34a 
Pull Request resolved: pytorch#136986
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984, pytorch#136985
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
Testing: Unblock new_* testing on MPS (pytorch#137003)
3f57e9e 
By changing `other_dtype` to `torch.half` rather than `double` in
`sample_inputs_new_fns` if MPS is available
Pull Request resolved: pytorch#137003
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984, pytorch#136985, pytorch#136986
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@malfet @AnantGulati
[MPS][BE] Use None as alias for all types (pytorch#137004)
0e707ea 
Test like `new_*` and `empty_*` fail the current implementation, see
Pull Request resolved: pytorch#137004
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984, pytorch#136985, pytorch#136986, pytorch#137003
@github-actions github-actions bot deleted the gh/malfet/20/head branch November 3, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @Skylion007 @pytorchmergebot