Testing: Unblock new_* testing on MPS
#137003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing `other_dtype` to `torch.half` rather than `double` in `sample_inputs_new_fns` if MPS is available [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137003
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit e8f1603 with merge base 156ca01 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 30, 2024
Skylion007
approved these changes
Sep 30, 2024
Skylion007
reviewed
Sep 30, 2024
| error_regex='margin_ranking_loss : All input tensors should') | ||
|
|
||
| def sample_inputs_new_fns(self, device, dtype, requires_grad, *, is_strided=False, **kwargs): | ||
| other_dtype = torch.half if torch.backends.mps.is_available() else torch.double |
There was a problem hiding this comment.
is there a better variable we can use to probe for float64 support?
There was a problem hiding this comment.
No, not really. Or at least I can't think of any. Also, this test perhaps should be further extended to pick different dtype if input dtype is torch.double/torch.half
By changing `other_dtype` to `torch.half` rather than `double` in `sample_inputs_new_fns` if MPS is available [ghstack-poisoned]
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
By changing `other_dtype` to `torch.half` rather than `double` in `sample_inputs_new_fns` if MPS is available Pull Request resolved: pytorch#137003 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984, pytorch#136985, pytorch#136986
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
Test like `new_*` and `empty_*` fail the current implementation, see Pull Request resolved: pytorch#137004 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#136981, pytorch#136982, pytorch#136983, pytorch#136984, pytorch#136985, pytorch#136986, pytorch#137003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Noneas alias for all types #137004new_*testing on MPS #137003nan_to_numfor bfloat16 #136986torch.linalg.crossfor bfloat16 #136984fmin/fmax/copysignandnextafterto blfoat #136982By changing
other_dtypetotorch.halfrather thandoubleinsample_inputs_new_fnsif MPS is available