AFAICT, compile workers never actually mocked torch #141491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141491
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b8c4c41 with merge base 4c1f50a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
Skylion007
approved these changes
Nov 25, 2024
Skylion007
reviewed
Nov 25, 2024
| dynamo_compile_column_us=None, | ||
| ): | ||
| yield | ||
| dynamo_timed = torch._dynamo.utils.dynamo_timed # type: ignore[has-type] |
There was a problem hiding this comment.
Ugh, is this type ignore still necessary?
jansel
approved these changes
Nov 25, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141492 Approved by: https://github.com/jansel ghstack dependencies: #141491
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Do code review with whitespace changes off. Check comments for what I changed. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141574 Approved by: https://github.com/bobrenjc93, https://github.com/jansel ghstack dependencies: #141491, #141492
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141654 Approved by: https://github.com/aorenste, https://github.com/jansel ghstack dependencies: #141491, #141492, #141574
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141491 Approved by: https://github.com/Skylion007, https://github.com/jansel
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141492 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141491
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Do code review with whitespace changes off. Check comments for what I changed. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141574 Approved by: https://github.com/bobrenjc93, https://github.com/jansel ghstack dependencies: pytorch#141491, pytorch#141492
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141654 Approved by: https://github.com/aorenste, https://github.com/jansel ghstack dependencies: pytorch#141491, pytorch#141492, pytorch#141574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov