Add README for torch._inductor.runtime #141492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141492
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 35e86f1 with merge base 4c1f50a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
topic: not user facing
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
jansel
requested changes
Nov 25, 2024
torch/_inductor/runtime/README.md
Outdated
Comment on lines
3
to
19
| There's not really a coherent concept for this folder; in general it contains | ||
| code for: | ||
|
|
||
| 1. Out-of-process Triton compilation (e.g., when doing multiprocess parallel | ||
| Triton compile) | ||
|
|
||
| 2. Code that is accessed by the code we generated in Inductor codegen (the | ||
| "runtime", although not really a true runtime because we don't actually run | ||
| this code when running, it's what the Triton compilation uses). | ||
|
|
||
| It isn't really a true runtime (aka, code that needs to be invoked when | ||
| actually running Inductor compiled kernels). | ||
|
|
||
| One of the original motivations for this directory split was so that the | ||
| subprocesses could access Triton and our compiler support code without having | ||
| to import torch. However, we never actually go this to work, so there are | ||
| still plenty of torch imports in this folder. |
There was a problem hiding this comment.
Suggested change
| There's not really a coherent concept for this folder; in general it contains | |
| code for: | |
| 1. Out-of-process Triton compilation (e.g., when doing multiprocess parallel | |
| Triton compile) | |
| 2. Code that is accessed by the code we generated in Inductor codegen (the | |
| "runtime", although not really a true runtime because we don't actually run | |
| this code when running, it's what the Triton compilation uses). | |
| It isn't really a true runtime (aka, code that needs to be invoked when | |
| actually running Inductor compiled kernels). | |
| One of the original motivations for this directory split was so that the | |
| subprocesses could access Triton and our compiler support code without having | |
| to import torch. However, we never actually go this to work, so there are | |
| still plenty of torch imports in this folder. | |
| This folder contains code needed at runtime by the output code of TorchInductor. The output code of TorchInductor will import `torch` and `torch._inductor.runtime`, but should not import from other files in `torch._inductor.*`. | |
| Runtime includes Triton/C++ compiles, which are compiled (sometimes in parallel) when the output code of TorchInductor is imported. It also includes the autotuning code and heuristics to decide block sizes of generated code. | |
| One of the original motivations for this directory split was so that the Triton compile | |
| subprocesses could access Triton and our compiler support code while mocking out most of `torch`, which can take seconds to import (sometimes more than a Triton compile itself). An abandoned prototype of this can be found [here](https://github.com/pytorch/pytorch/pull/124682/files). |
-
This directory does contain the code needed to run Inductor compiled kernels/code. In that sense I think it is a true runtime and I think this directory structure makes sense even without the MockTorch stuff landing.
-
Not importing
torchis not a requirement of the prototype in [inductor] Add thread+subproc-based worker_start_method #124682 --tritonimports torch, so that requirement is clearly not attainable. Instead, the prototype mocks out torch by doing:
sys.modules["torch"] = MockTorch()
with some trickery to allow only files inside torch to be imported.
There was a problem hiding this comment.
I took this suggestion and reworded a little bit of it
jansel
approved these changes
Nov 25, 2024
|
@pytorchbot merge -f "unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Do code review with whitespace changes off. Check comments for what I changed. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141574 Approved by: https://github.com/bobrenjc93, https://github.com/jansel ghstack dependencies: #141491, #141492
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141654 Approved by: https://github.com/aorenste, https://github.com/jansel ghstack dependencies: #141491, #141492, #141574
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141492 Approved by: https://github.com/jansel ghstack dependencies: pytorch#141491
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Do code review with whitespace changes off. Check comments for what I changed. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141574 Approved by: https://github.com/bobrenjc93, https://github.com/jansel ghstack dependencies: pytorch#141491, pytorch#141492
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141654 Approved by: https://github.com/aorenste, https://github.com/jansel ghstack dependencies: pytorch#141491, pytorch#141492, pytorch#141574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov