[ROCm] devtoolset / GCC11 upgrade on manylinux images - 1b of 2 (docker images) #141609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141609
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit 22d1987 with merge base 8ba555e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/rocm
jeffdaily
approved these changes
Nov 26, 2024
jithunnair-amd
changed the title
jithunnair-amd
changed the title
|
The manylinux docker image build with LDFLAGS set to point to gcc-toolset-11 succeeded for 6.2.4 and 6.1. The wheel builds using the above images also succeeded in PR 141423: eg. https://github.com/pytorch/pytorch/actions/runs/12068334721/job/33653245377 However, the wheel test jobs failed because they do not have AWS access set up, so we need to blind merge this PR to enable these changes to reflect in the dockerhub |
|
@pytorchbot merge -f "ROCm CI builds passed. ROCm test failures and other CI failures are unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Depends on #140681 and #141609 Highlights: * Upgrade binaries to ROCm6.2.4 to use latest docker images * Remove pre-cxx11 builds for libtorch on ROCm * Use manylinux2_28 docker images for ROCm * Set `DESIRED_DEVTOOLSET=cxx-abi` (and hence `_GLIBCXX_USE_CXX11_ABI=1`) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent) Pull Request resolved: #141423 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…er images) (pytorch#141609) Upgrade gcc version from 9 to 11 on ROCm manylinux images. Needed for pytorch#141423 since almalinux8-based manylinux2_28 images for ROCm (pytorch#140681) installs gcc-toolset-9, which installs [gcc 9.2.1](https://pkgs.org/download/gcc-toolset-9-gcc-c++). However, PyTorch CMakeLists.txt enforces a [minimum gcc version of 9.3](https://github.com/pytorch/pytorch/blob/5318bf8baf19fecda365c185cd81196e3cfb08e3/CMakeLists.txt#L61). Pull Request resolved: pytorch#141609 Approved by: https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com>
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
) Depends on pytorch#140681 and pytorch#141609 Highlights: * Upgrade binaries to ROCm6.2.4 to use latest docker images * Remove pre-cxx11 builds for libtorch on ROCm * Use manylinux2_28 docker images for ROCm * Set `DESIRED_DEVTOOLSET=cxx-abi` (and hence `_GLIBCXX_USE_CXX11_ABI=1`) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent) Pull Request resolved: pytorch#141423 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>
5 tasks
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
) Depends on pytorch#140681 and pytorch#141609 Highlights: * Upgrade binaries to ROCm6.2.4 to use latest docker images * Remove pre-cxx11 builds for libtorch on ROCm * Use manylinux2_28 docker images for ROCm * Set `DESIRED_DEVTOOLSET=cxx-abi` (and hence `_GLIBCXX_USE_CXX11_ABI=1`) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent) Pull Request resolved: pytorch#141423 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>
This was referenced Jun 12, 2025
jithunnair-amd
added a commit
to ROCm/builder
that referenced
this pull request
Jun 13, 2025
### Motivation: * Use newer devtoolset11 to sync with upstream: pytorch/pytorch#141609 ### Changes: * Use devtoolset 11 * Set LDFLAGS and DEVTOOLSET_VERSION (cherry picked from commit a80f1ef) Relates to: ROCm/rocAutomation#937 Validation: * 2.7: http://rocm-ci.amd.com/job/pytorch-pipeline-manylinux-wheel-builder_rel-6.4/379/ * 2.5: http://rocm-ci.amd.com/job/pytorch-pipeline-manylinux-wheel-builder_rel-6.4/400/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade gcc version from 9 to 11 on ROCm manylinux images.
Needed for #141423 since almalinux8-based manylinux2_28 images for ROCm (#140681) installs gcc-toolset-9, which installs gcc 9.2.1. However, PyTorch CMakeLists.txt enforces a minimum gcc version of 9.3.
cc @jeffdaily @sunway513 @jithunnair-amd @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd