KEMBAR78
[PT2E Quantization] Fix RecursionError when prepare_pt2e graph with concat of the same node by siahuat0727 · Pull Request #141651 · pytorch/pytorch · GitHub
Skip to content

[PT2E Quantization] Fix RecursionError when prepare_pt2e graph with concat of the same node #141651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[PT2E Quantization] Fix RecursionError when prepare_pt2e graph with concat of the same node #141651

wants to merge 2 commits into from

Conversation

@siahuat0727
Copy link
Contributor

@siahuat0727 siahuat0727 commented Nov 27, 2024 •
edited by pytorch-bot bot
Loading

Fixes #129038

Related PR #129567

Here is the new PR against main, thanks! @jerryzh168

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141651

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9b8025e with merge base 5212ec3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2024

Please seek CI approval before scheduling CIFlow labels

@siahuat0727
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 19 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@siahuat0727
Copy link
Contributor Author

Hi @jerryzh168, is there anything else I need to do to move this PR towards being merged? Thanks.

@jerryzh168
Copy link
Contributor

not sure what is happening with the CI, maybe you can rebase on main and try again

@siahuat0727 siahuat0727 force-pushed the fix-pt2e-concat-same-node branch from 5a856ce to 9b8025e Compare November 28, 2024 08:00
@siahuat0727
Copy link
Contributor Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@siahuat0727
Copy link
Contributor Author

Hi @jerryzh168, everything looks good so far, but additional approval is needed. Please take a look when you get a chance.

@siahuat0727
Copy link
Contributor Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

GeorgeWigley pushed a commit to graphcore/pytorch-fork that referenced this pull request Nov 29, 2024
@siahuat0727 @GeorgeWigley
[PT2E Quantization] Fix RecursionError when prepare_pt2e graph with c…
3a767cb 
…oncat of the same node (pytorch#141651)

Fixes pytorch#129038

Related PR pytorch#129567

Here is the new PR against main, thanks! @jerryzh168

Pull Request resolved: pytorch#141651
Approved by: https://github.com/jerryzh168
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@siahuat0727
[PT2E Quantization] Fix RecursionError when prepare_pt2e graph with c…
88c9f5f 
…oncat of the same node (pytorch#141651)

Fixes pytorch#129038

Related PR pytorch#129567

Here is the new PR against main, thanks! @jerryzh168

Pull Request resolved: pytorch#141651
Approved by: https://github.com/jerryzh168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged open source release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PT2E Quantization] Graph with concatenation of the same node will raise RecursionError when prepare_pt2e

5 participants

@siahuat0727 @pytorchmergebot @jerryzh168 @facebook-github-bot @pytorchbot