KEMBAR78
inductor.config.descriptive_names = False is not actually supported by exclamaforte · Pull Request #145523 · pytorch/pytorch · GitHub
Skip to content

inductor.config.descriptive_names = False is not actually supported #145523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

inductor.config.descriptive_names = False is not actually supported #145523

wants to merge 1 commit into from

Conversation

exclamaforte
Copy link
Contributor

@exclamaforte exclamaforte commented Jan 23, 2025 •
edited
Loading

@exclamaforte exclamaforte requested a review from eellison January 23, 2025 20:44
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145523

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 325c90e with merge base a08f7f3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 21:14 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 21:14 Inactive
@masnesral
Copy link
Contributor

seems legit, but I don't know the history, so defer to @eellison

@exclamaforte exclamaforte mentioned this pull request Jan 24, 2025
Closed
@eellison
Copy link
Contributor

deferring to @Chillee from blame

@eellison eellison requested review from Chillee and removed request for Chillee and eellison January 27, 2025 19:49
@Chillee
Copy link
Collaborator

Chillee commented Jan 28, 2025

I think we might have made this not work - I'd be fine with deleting this now.

@exclamaforte
Copy link
Contributor Author

Cool, could someone hit the approve button?

@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 13 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@exclamaforte
inductor.config.descriptive_names = False is not actually supported
325c90e 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@exclamaforte exclamaforte force-pushed the exclamaforte/remove-desc-names branch from f09b2aa to 325c90e Compare January 28, 2025 16:49
@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 17:19 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 17:19 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 17:21 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 17:21 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 17:21 Inactive
@ZainRizvi
Copy link
Contributor

@pytorchbot revert -c ghfirst -m "Hi, this breaks type checks internally. Can you please take a look? See D68801083 for details"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jan 29, 2025
@pytorchmergebot
Revert "inductor.config.descriptive_names = False is not actually sup…
e0525db 
…ported (#145523)"

This reverts commit edf266e.

Reverted #145523 on behalf of https://github.com/ZainRizvi due to Hi, this breaks type checks internally. Can you please take a look? See D68801083 for details ([comment](#145523 (comment)))
@pytorchmergebot
Copy link
Collaborator

@exclamaforte your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jan 29, 2025
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 18:59 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 18:59 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 18:59 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 18:59 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 18:59 Inactive
pytorch-bot bot pushed a commit that referenced this pull request Jan 30, 2025
@exclamaforte @facebook-github-bot
inductor.config.descriptive_names = False is not actually supported (#…
8ffe98c 
…145523) (#145523)

Summary:
This config is not supported (it throws an error when set), and doesn't really make sense imo.

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82

Differential Revision: D68846308
carmocca pushed a commit to carmocca/pytorch that referenced this pull request Feb 12, 2025
@exclamaforte @pytorchmergebot
Refactor fuzzer and add support for Dynamo (pytorch#145565)
f16ce3c 
## Summary:
Dynamo now works with config fuzzer.

For BE week, we also found and fixed 5 different bugs (in inductor):
- pytorch#145426
- pytorch#145523
- pytorch#145527
- pytorch#145532
- pytorch#145538

## Test Plan:
New Dynamo Unit tests

Pull Request resolved: pytorch#145565
Approved by: https://github.com/masnesral
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Mar 30, 2025
pytorch-bot bot pushed a commit that referenced this pull request Apr 16, 2025
@exclamaforte @facebook-github-bot
inductor.config.descriptive_names = False is not actually supported (#…
90e4d10 
…145523) (#146051)

Summary:

This config is not supported (it throws an error when set), and doesn't really make sense imo.

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82

Reviewed By: masnesral

Differential Revision: D68846308
pytorchmergebot pushed a commit that referenced this pull request Apr 19, 2025
@exclamaforte @pytorchmergebot
inductor.config.descriptive_names = False is not actually supported (#…
cfc4d74 
…145523) (#146051) (#151481)

Summary:

This config is not supported (it throws an error when set), and doesn't really make sense imo.

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82

Reviewed By: masnesral

Differential Revision: D68846308

Pull Request resolved: #151481
Approved by: https://github.com/masnesral
pytorchmergebot added a commit that referenced this pull request Apr 19, 2025
@pytorchmergebot
Revert "inductor.config.descriptive_names = False is not actually sup…
6261db7 
…ported (#145523) (#146051) (#151481)"

This reverts commit cfc4d74.

Reverted #151481 on behalf of https://github.com/malfet due to It indeed breaks lint, it followup PR contains it's own issues ([comment](#151481 (comment)))
@github-actions github-actions bot deleted the exclamaforte/remove-desc-names branch May 25, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@masnesral masnesral Awaiting requested review from masnesral

@Chillee Chillee Awaiting requested review from Chillee

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor Reverted Stale topic: deprecation topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@exclamaforte @masnesral @eellison @Chillee @pytorchmergebot @ZainRizvi