inductor.config.descriptive_names = False is not actually supported (#145523) (#146051) #151481

exclamaforte · 2025-04-16T21:48:56Z

Summary:

This config is not supported (it throws an error when set), and doesn't really make sense imo.

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82

Reviewed By: masnesral

Differential Revision: D68846308

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

…ytorch#145523) (pytorch#146051) Summary: This config is not supported (it throws an error when set), and doesn't really make sense imo. Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82 Reviewed By: masnesral Differential Revision: D68846308

pytorch-bot · 2025-04-16T21:48:59Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151481

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[Infra] Jobs got intermittently cancelled/fail midway checkout

❌ 1 New Failure, 2 Cancelled Jobs, 11 Unrelated Failures

As of commit 90e4d10 with merge base cd7bc60 ():

NEW FAILURE - The following job has failed:

Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/_inductor/config.py:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

inductor / unit-test / cuda12.6-py3.13-gcc9-sm86 / build (gh)
##[error]The operation was canceled.
trunk / cuda12.4-py3.10-gcc9-sm80 / build (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
inductor / unit-test / cuda12.6-py3.12-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 2, 5, lf.ephemeral.linux.4xlarge.nvidia.gpu) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 3, 5, lf.ephemeral.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.13-clang10 / test (default, 4, 5, lf.ephemeral.linux.4xlarge) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.9-clang10 / test (default, 3, 5, lf.ephemeral.linux.4xlarge) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, lf.ephemeral.linux.4xlarge) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-jammy-py3.9-gcc11 / test (default, 2, 5, lf.ephemeral.linux.2xlarge) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (disabled by #148093 but the issue was closed recently and a rebase is needed to make it pass)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-04-16T21:49:06Z

This pull request was exported from Phabricator. Differential Revision: D68846308

Camyll · 2025-04-18T23:25:39Z

@pytorchbot merge

pytorchmergebot · 2025-04-18T23:27:28Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-18T23:27:37Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Camyll · 2025-04-19T00:03:25Z

@pytorchbot merge -i

Camyll · 2025-04-19T00:03:47Z

will land lintrunner fix on top of this PR #151725

pytorchmergebot · 2025-04-19T00:05:14Z

Merge started

Your change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2025-04-19T03:11:22Z

@pytorchbot revert -m "It indeed breaks lint, it followup PR contains it's own issues" -c weird

pytorchmergebot · 2025-04-19T03:12:49Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…ported (#145523) (#146051) (#151481)" This reverts commit cfc4d74. Reverted #151481 on behalf of https://github.com/malfet due to It indeed breaks lint, it followup PR contains it's own issues ([comment](#151481 (comment)))

pytorchmergebot · 2025-04-19T03:12:59Z

@exclamaforte your PR has been successfully reverted.
⚠️ This PR might contain internal changes
cc: @pytorch/pytorch-dev-infra

fixes broken lint tests in #151481 Pull Request resolved: #151725 Approved by: https://github.com/exclamaforte, https://github.com/Skylion007 Co-authored-by: Gabriel Ferns <gabeferns@meta.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>

github-actions · 2025-06-18T12:47:12Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

pytorch-bot bot added ciflow/inductor module: inductor labels Apr 16, 2025

facebook-github-bot added the fb-exported label Apr 16, 2025

exclamaforte added release notes: inductor topic: deprecation topic category labels Apr 16, 2025

exclamaforte requested a review from masnesral April 17, 2025 00:02

masnesral approved these changes Apr 17, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 17, 2025

pytorchmergebot added the merging label Apr 18, 2025

pytorchmergebot removed the merging label Apr 18, 2025

Camyll mentioned this pull request Apr 19, 2025

run lintrunner for Export d68846308 #151725

Closed

pytorchmergebot added the merging label Apr 19, 2025

pytorchmergebot added the Merged label Apr 19, 2025

pytorchmergebot closed this in cfc4d74 Apr 19, 2025

pytorchmergebot removed the merging label Apr 19, 2025

pytorchmergebot added the Reverted label Apr 19, 2025

pytorchmergebot added the ci-no-td Do not run TD on this PR label Apr 19, 2025

pytorchmergebot reopened this Apr 19, 2025

github-actions bot added the Stale label Jun 18, 2025

github-actions bot closed this Jul 18, 2025

inductor.config.descriptive_names = False is not actually supported (#145523) (#146051) #151481

inductor.config.descriptive_names = False is not actually supported (#145523) (#146051) #151481

Uh oh!

Conversation

exclamaforte commented Apr 16, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151481

❗ 1 Active SEVs

❌ 1 New Failure, 2 Cancelled Jobs, 11 Unrelated Failures

Uh oh!

facebook-github-bot commented Apr 16, 2025

Uh oh!

Camyll commented Apr 18, 2025

Uh oh!

pytorchmergebot commented Apr 18, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 18, 2025

Merge failed

Uh oh!

Camyll commented Apr 19, 2025

Uh oh!

Camyll commented Apr 19, 2025

Uh oh!

pytorchmergebot commented Apr 19, 2025

Merge started

Uh oh!

malfet commented Apr 19, 2025

Uh oh!

pytorchmergebot commented Apr 19, 2025

Uh oh!

pytorchmergebot commented Apr 19, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

exclamaforte commented Apr 16, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Apr 16, 2025 •

edited

Loading