Revert "Cleanup VS 2019 refs in pytorch (#145863)" (#152613) #153390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2613) This reverts commit b45e6fa. revert PRs: pytorch#145863 pytorch#145319 Pull Request resolved: pytorch#152613 Approved by: https://github.com/atalman, https://github.com/malfet
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153390
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 1 Unrelated FailureAs of commit 3760272 with merge base 924a247 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ci-no-td
xuhancn
added
ciflow/binaries
xuhancn
added
module: windows
|
I have tested it pass locally: CC: @atalman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b45e6fa.
revert PRs:
#145863
#145319
Pull Request resolved: #152613
Approved by: https://github.com/atalman, https://github.com/malfet
Fixes #152385
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168