KEMBAR78
Windows builds with VS2022 by Camyll · Pull Request #145319 · pytorch/pytorch · GitHub
Skip to content

Windows builds with VS2022 #145319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Windows builds with VS2022 #145319

wants to merge 1 commit into from

Conversation

Camyll
Copy link
Contributor

@Camyll Camyll commented Jan 21, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145319

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e8d6b2 with merge base 2de53b3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 21, 2025
@Camyll Camyll force-pushed the camyllh_update_vs_build_to_2022 branch from be24e82 to 9e8d6b2 Compare January 27, 2025 22:44
@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR test-config/default labels Jan 28, 2025
@huydhn
Copy link
Contributor

huydhn commented Jan 28, 2025

For this, you will need ciflow/binaries_wheel to start the build on PR for testing. Here is the current run https://github.com/pytorch/pytorch/actions/runs/13000860457

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 00:41 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 00:41 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 00:41 Inactive
@huydhn huydhn changed the title windows builds with VS2022 Windows builds with VS2022 Jan 28, 2025
@huydhn
Copy link
Contributor

huydhn commented Jan 28, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor

huydhn commented Jan 28, 2025

All tests look green, let me double check to confirm VS2022 is used

huydhn
huydhn approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build looks correct https://github.com/pytorch/pytorch/actions/runs/13000860457/job/36306992299#step:11:128

@huydhn
Copy link
Contributor

huydhn commented Jan 28, 2025

I think we need a small tweak to go with it by switching this to VS2022 https://github.com/pytorch/pytorch/blob/main/.circleci/scripts/binary_windows_test.sh#L7. However, that can be done in the clean up PR to remove VS2019 I think.

@Camyll
Copy link
Contributor Author

Camyll commented Jan 28, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Jan 28, 2025
Closed
Merged
Camyll added a commit to pytorch/test-infra that referenced this pull request Feb 5, 2025
@Camyll
remove visual studio 2019 install in test infra (#6226)
5948c70 
Original Issue: pytorch/pytorch#128835
Follow up on PR: pytorch/pytorch#145319
pytorchmergebot pushed a commit that referenced this pull request Feb 10, 2025
@Camyll @pytorchmergebot
Cleanup VS 2019 refs in pytorch (#145863)
b45e6fa 
Related to: #128835
Follow up on PR: #145319
Pull Request resolved: #145863
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/huydhn, https://github.com/atalman
This was referenced Feb 20, 2025
Open
Closed
@github-actions github-actions bot deleted the camyllh_update_vs_build_to_2022 branch February 28, 2025 02:11
This was referenced May 1, 2025
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request May 10, 2025
@xuhancn @pytorchmergebot
Revert "Cleanup VS 2019 refs in pytorch (#145863)" (#152613)
e4f2282 
This reverts commit b45e6fa.

revert PRs:
#145863
#145319

Pull Request resolved: #152613
Approved by: https://github.com/atalman, https://github.com/malfet
xuhancn added a commit to xuhancn/pytorch that referenced this pull request May 12, 2025
@xuhancn
Revert "Cleanup VS 2019 refs in pytorch (pytorch#145863)" (pytorch#15…
3760272 
…2613)

This reverts commit b45e6fa.

revert PRs:
pytorch#145863
pytorch#145319

Pull Request resolved: pytorch#152613
Approved by: https://github.com/atalman, https://github.com/malfet
@xuhancn xuhancn mentioned this pull request May 12, 2025
Merged
atalman pushed a commit that referenced this pull request May 14, 2025
@xuhancn
Revert "Cleanup VS 2019 refs in pytorch (#145863)" (#152613) (#153390)
800aa04 
This reverts commit b45e6fa.

revert PRs:
#145863
#145319

Pull Request resolved: #152613
Approved by: https://github.com/atalman, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Camyll @huydhn @pytorchmergebot