Cleanup VS 2019 refs in pytorch #145863

Camyll · 2025-01-28T19:26:12Z

Related to: #128835
Follow up on PR: #145319

pytorch-bot · 2025-01-28T19:26:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145863

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b57b38b with merge base 99dd846 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn · 2025-01-28T21:55:04Z

.circleci/scripts/binary_windows_build.sh

+export VC_YEAR=2022

 if [[ "$DESIRED_CUDA" == 'xpu' ]]; then
    export VC_YEAR=2022


Nit: You could also remove this line

huydhn · 2025-01-28T21:56:08Z

Searching for vs2019 and there are some additional files / references we can remove I think https://github.com/search?q=repo%3Apytorch%2Fpytorch%20vs2019&type=code

malfet

If it works, then sure...

malfet · 2025-01-28T23:23:08Z

.github/workflows/pull.yml

    secrets: inherit

-  win-vs2019-cpu-py3-build:
+  win-vs2022-cpu-py3-build:


Alas, this is a no-op, as VC version is defined by AMI

Yeah, we are going to clean up the AMI next

Camyll · 2025-02-06T00:03:01Z

@pytorchbot merge

pytorchmergebot · 2025-02-06T00:04:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-02-06T00:04:56Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Camyll · 2025-02-07T22:54:20Z

@pytorchbot merge

pytorchmergebot · 2025-02-07T22:56:04Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-02-07T23:07:14Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_12-rocm6_3-build / build

Details for Dev Infra team

Raised by workflow job

huydhn · 2025-02-10T18:57:45Z

@pytorchbot merge

pytorchmergebot · 2025-02-10T18:59:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

seemethere · 2025-02-11T00:09:44Z

.github/workflows/trunk.yml

      test-matrix: ${{ needs.macos-py3-arm64-build.outputs.test-matrix }}
    secrets: inherit

-  win-vs2019-cpu-py3-build:


Does this mean that we're not testing windows at all anymore?

I've same concern here, I didn't see any replacement for PR tests on Windows, it is just removed.
Will you add it in a separate PR?

Oops, I don't think this was in the original PR before. @Camyll Could you submit a PR to revert the last commit you have b57b38b and put these jobs back? You want to rename them from vs2019 to vs2022 instead

This reverts commit b45e6fa.

This reverts commit b45e6fa. revert PRs: #145863 #145319 Pull Request resolved: #152613 Approved by: https://github.com/atalman, https://github.com/malfet

…2613) This reverts commit b45e6fa. revert PRs: pytorch#145863 pytorch#145319 Pull Request resolved: pytorch#152613 Approved by: https://github.com/atalman, https://github.com/malfet

This reverts commit b45e6fa. revert PRs: #145863 #145319 Pull Request resolved: #152613 Approved by: https://github.com/atalman, https://github.com/malfet

…52613) This reverts commit e4f2282.

This reverts commit e4f2282. I believe fix PR was landed #153480 that triggered the revert. Hence this is reland. Pull Request resolved: #155478 Approved by: https://github.com/malfet

Camyll requested a review from a team as a code owner January 28, 2025 19:26

pytorch-bot bot added the release notes: releng release notes category label Jan 28, 2025

Skylion007 approved these changes Jan 28, 2025

View reviewed changes

Skylion007 added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jan 28, 2025

huydhn added the test-config/default label Jan 28, 2025

huydhn reviewed Jan 28, 2025

View reviewed changes

malfet approved these changes Jan 28, 2025

View reviewed changes

huydhn approved these changes Jan 28, 2025

View reviewed changes

huydhn mentioned this pull request Jan 29, 2025

remove visual studio 2019 install in test infra pytorch/test-infra#6226

Merged

cyyever changed the title ~~Cleanup VS 2019 refs in pytorch pytorch~~ Cleanup VS 2019 refs in pytorch Jan 29, 2025

atalman approved these changes Jan 31, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 6, 2025

pytorchmergebot added the merging label Feb 6, 2025

pytorchmergebot removed the merging label Feb 6, 2025

Camyll added 3 commits February 6, 2025 13:27

remove VS 2019 refs

8cf9542

remove more refs to vs2019

7b19d75

remove unnecessary line

22c091a

Camyll force-pushed the cleanup_vs_2019 branch from fecbf52 to 22c091a Compare February 6, 2025 21:28

remove noop

b57b38b

pytorchmergebot added the merging label Feb 7, 2025

pytorchmergebot removed the merging label Feb 7, 2025

pytorchmergebot added the merging label Feb 10, 2025

pytorchmergebot added the Merged label Feb 10, 2025

pytorchmergebot closed this in b45e6fa Feb 10, 2025

pytorchmergebot removed the merging label Feb 10, 2025

seemethere reviewed Feb 11, 2025

View reviewed changes

Camyll mentioned this pull request Feb 11, 2025

win-vs2022-cpu-py3 test failures in test-default-2-3-lf.windows.4xlarge.nonephemeral_37054642004 #146944

Open

github-actions bot deleted the cleanup_vs_2019 branch March 14, 2025 02:08

xuhancn mentioned this pull request Apr 16, 2025

PyTorch VS2022 official build Windows binary illegal instruction on AVX2(max ISA level) CPU #145702

Open

xuhancn mentioned this pull request May 1, 2025

Illegal Instruction Caused by grid_sample Under Windows #152385

Closed

xuhancn added a commit to xuhancn/pytorch that referenced this pull request May 1, 2025

Revert "Cleanup VS 2019 refs in pytorch (pytorch#145863)"

fba5ce1

This reverts commit b45e6fa.

xuhancn mentioned this pull request May 1, 2025

Revert "Cleanup VS 2019 refs in pytorch (#145863)" #152613

Closed

xuhancn added a commit to xuhancn/pytorch that referenced this pull request May 1, 2025

Revert "Cleanup VS 2019 refs in pytorch (pytorch#145863)"

724649a

This reverts commit b45e6fa.

xuhancn added a commit to xuhancn/pytorch that referenced this pull request May 10, 2025

Revert "Cleanup VS 2019 refs in pytorch (pytorch#145863)"

6159e77

This reverts commit b45e6fa.

xuhancn mentioned this pull request May 12, 2025

Revert "Cleanup VS 2019 refs in pytorch (#145863)" (#152613) #153390

Merged

atalman added a commit to atalman/pytorch that referenced this pull request Jun 9, 2025

Reapply "Cleanup VS 2019 refs in pytorch (pytorch#145863)" (pytorch#1…

914f393

…52613) This reverts commit e4f2282.

Cleanup VS 2019 refs in pytorch #145863

Cleanup VS 2019 refs in pytorch #145863

Uh oh!

Conversation

Camyll commented Jan 28, 2025

Uh oh!

pytorch-bot bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145863

✅ No Failures

Uh oh!

huydhn Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

huydhn commented Jan 28, 2025

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

malfet Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

huydhn Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

Camyll commented Feb 6, 2025

Uh oh!

pytorchmergebot commented Feb 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Feb 6, 2025

Merge failed

Uh oh!

Camyll commented Feb 7, 2025

Uh oh!

pytorchmergebot commented Feb 7, 2025

Merge started

Uh oh!

pytorchmergebot commented Feb 7, 2025

Merge failed

Uh oh!

huydhn commented Feb 10, 2025

Uh oh!

pytorchmergebot commented Feb 10, 2025

Merge started

Uh oh!

seemethere Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

huydhn Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Camyll Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pytorch-bot bot commented Jan 28, 2025 •

edited

Loading