KEMBAR78
[BE] Raise `NotImplementedError` by malfet · Pull Request #155470 · pytorch/pytorch · GitHub
Skip to content

[BE] Raise NotImplementedError #155470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[BE] Raise NotImplementedError #155470

wants to merge 5 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 9, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

When op is unimplemented for a specific dtype

Which makes more sense, than a RuntimeError

Example

>>> import torch
>>> torch.nn.Hardshrink()(torch.randint(0, 5, (10,)))
NotImplementedError: "hardshrink_cpu" not implemented for 'Long'

release notes bc-breaking: After this release NotImplementedError exception will be raised when ATen operation is called on the combinaiton of input tensor dtypes it has not been implemented for

Mark few more unary ops as unimplemented to satisfy foreach testing error reporting consistency between CPU and CUDA

cc @albanD

@malfet
Update
22989c1 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155470

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 31d2853 with merge base 9f5153b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested review from Skylion007 and albanD June 9, 2025 17:42
@malfet malfet added topic: bc breaking topic category module: python frontend For issues relating to PyTorch's Python frontend labels Jun 9, 2025
albanD
albanD approved these changes Jun 9, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, not sure how actually BC-breaking it is though

@malfet
Copy link
Contributor Author

malfet commented Jun 9, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2025
@malfet malfet added release notes: python_frontend python frontend release notes category and removed module: python frontend For issues relating to PyTorch's Python frontend labels Jun 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Jun 9, 2025

@malfet please add the release notes bc-breaking note to the PR description

@malfet malfet mentioned this pull request Jun 9, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Update
86da692 
[ghstack-poisoned]
@malfet
Update
d73f4ca 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jun 12, 2025
@malfet
[BE] Raise NotImplementedError
03e1c0f 
When op is unimplemented for a specific dtype

Which makes more sense, than a RuntimeError

ghstack-source-id: 5bf8cb5
Pull Request resolved: #155470
@malfet
Copy link
Contributor Author

malfet commented Jun 12, 2025

@pytorchbot merge -f "This seems fine?"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Jun 13, 2025

@pytorchbot revert -m "foreach tests are failing on ROCm because we are not running the same on CUDA"

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 13, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor Author

malfet commented Jun 13, 2025

@pytorchbot revert -m "foreach tests are failing on ROCm because we are not running the same on CUDA" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jun 13, 2025
@pytorchmergebot
Revert "[BE] Raise NotImplementedError (#155470)"
ce6e052 
This reverts commit 5ab6a3f.

Reverted #155470 on behalf of https://github.com/malfet due to foreach tests are failing on ROCm because we are not running the same on CUDA ([comment](#155470 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jun 13, 2025
@malfet
Update
58eac69 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jun 13, 2025
@malfet
[BE] Raise NotImplementedError
1ba14cd 
When op is unimplemented for a specific dtype

Which makes more sense, than a RuntimeError

ghstack-source-id: 6523a1f
Pull Request resolved: #155470
@malfet
Update
31d2853 
[ghstack-poisoned]
This was referenced Jun 13, 2025
Closed
Closed
@malfet
Copy link
Contributor Author

malfet commented Jun 13, 2025

@pytorchbot merge -f "Trunk is red, Tests are green, Merging this PR— Best I've seen!"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jun 13, 2025
@malfet @pytorchmergebot
[BE] Refactor clamp dtypes check (#155930)
d512584 
By introducing `check_for_unsupported_clamp_dtypes` similar to `check_for_unsupported_isin_dtypes`
Pull Request resolved: #155930
Approved by: https://github.com/albanD, https://github.com/janeyx99, https://github.com/clee2000
ghstack dependencies: #155470
@github-actions github-actions bot deleted the gh/malfet/387/head branch July 14, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category Reverted topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @albanD @Skylion007