KEMBAR78
[BE] Refactor clamp dtypes check by malfet · Pull Request #155930 · pytorch/pytorch · GitHub
Skip to content

[BE] Refactor clamp dtypes check #155930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BE] Refactor clamp dtypes check #155930

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 13, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

By introducing check_for_unsupported_clamp_dtypes similar to check_for_unsupported_isin_dtypes

@malfet
Update
1e4e3e9 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Jun 13, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155930

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1e4e3e9 with merge base 9f5153b (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Jun 13, 2025
@malfet
[BE] Refactor clamp dtypes check
20828b5 
By introducing `check_for_unsupported_clamp_dtypes` similar to `check_for_unsupported_isin_dtypes`

ghstack-source-id: 0487e11
Pull Request resolved: #155930
@malfet malfet requested a review from Skylion007 June 13, 2025 17:51
albanD
albanD approved these changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

janeyx99
janeyx99 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oki

@malfet malfet added the topic: not user facing topic category label Jun 13, 2025
@malfet
Copy link
Contributor Author

malfet commented Jun 13, 2025

@pytorchbot merge -f "I don't know what to write here"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/401/head branch July 14, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@clee2000 clee2000 clee2000 approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @albanD @janeyx99 @clee2000