Grab bag of (mostly) typing improvements #158075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminglass1
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158075
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c00bba8 with merge base 70b4a88 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5 tasks
Skylion007
approved these changes
Jul 12, 2025
Skylion007
reviewed
Jul 13, 2025
benjaminglass1
added
topic: not user facing
|
BC lint is failing on updating some existing types from |
benjaminglass1
added
the
suppress-bc-linter
|
With this amount of test failures, I'm going to back out the changes to |
benjaminglass1
removed
the
suppress-bc-linter
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jul 23, 2025
Summary: Collects some scattershot improvements made while attempting to enable training for AOTInductor. Non-typing changes are: 1. Swapping a few custom searches for the output node in an FX graph for calling `graph.output_node()`. 2. Removing two unused parameters from `torch.export._unlift._unlift`. 3. Switching handles to constants in `cpp_wrapper_cpu` to use C++ references for memory efficiency. 4. Cleaning out unused, unexported imports from `torch/export/__init__.py`, and adding one missing export to `__all__`. X-link: pytorch/pytorch#158075 Approved by: https://github.com/Skylion007 Reviewed By: ZainRizvi Differential Revision: D78691998 fbshipit-source-id: cdd51fe27cef89786ac7728775c103f5c11fcb1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Collects some scattershot improvements made while attempting to enable training for AOTInductor. Non-typing changes are:
graph.output_node().torch.export._unlift._unlift.cpp_wrapper_cputo use C++ references for memory efficiency.torch/export/__init__.py, and adding one missing export to__all__.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela