KEMBAR78
Move c10/macros/Macros.h to headeronly by janeyx99 · Pull Request #158365 · pytorch/pytorch · GitHub
Skip to content

Move c10/macros/Macros.h to headeronly #158365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Move c10/macros/Macros.h to headeronly #158365

wants to merge 3 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 15, 2025 •
edited
Loading

@janeyx99 janeyx99 mentioned this pull request Jul 15, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 21 New Failures, 1 Unrelated Failure

As of commit 66fcb3a with merge base ee09928 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78361893

@janeyx99 janeyx99 added ciflow/trunk Trigger trunk jobs on your pull request release notes: build release notes category labels Jul 15, 2025
janeyx99 added a commit that referenced this pull request Jul 15, 2025
@janeyx99
Move c10/macros/Macros.h to headeronly
c9b628c 
Pull Request resolved: #158365

^

Differential Revision: [D78361893](https://our.internmc.facebook.com/intern/diff/D78361893/)
ghstack-source-id: 296389104
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78361893

@janeyx99 janeyx99 mentioned this pull request Jul 15, 2025
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78361893

@janeyx99 janeyx99 mentioned this pull request Jul 16, 2025
Closed
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 21 jobs have failed, first few of them are: docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11), docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-cuda12.6-cudnn9-py3.13-gcc9-inductor-benchmarks), docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-cuda12.6-cudnn9-py3-gcc9-inductor-benchmarks), docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-cuda12.8-cudnn9-py3.13-gcc9-inductor-benchmarks), docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc9)

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

@pytorchbot merge -f "CI is fine on the PR stacked on top of this one?"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2025
@janeyx99 @pytorchmergebot
[BE] Get rid of final mentions of BUILD_SPLIT_CUDA (#158453)
09db3a2 
BUILD_SPLIT_CUDA logic has been removed for a while

Differential Revision: [D78418191](https://our.internmc.facebook.com/intern/diff/D78418191/)
Pull Request resolved: #158453
Approved by: https://github.com/albanD
ghstack dependencies: #158358, #158365
@github-actions github-actions bot deleted the gh/janeyx99/277/head branch August 16, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swolchok swolchok swolchok approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: build release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @facebook-github-bot @pytorchmergebot @swolchok